-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime lib restructure #202
Conversation
✅ Deploy Preview for docs-oz-polkadot ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard to review closely as with any PR that moves configs between files, but I agree it's worth it for improved organization moving forward.
I think we should follow the same structure for the evm-template as well and it'd be easier to review those changes if they were included in this PR.
If I refactor evm-template right now, there will be so many conflicts. As I mentioned, I think I have to wait for evm-template PR's to merge first |
f903b48
to
d849f53
Compare
78f33a9
to
3237ba0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suspicious file, in other things LGTM!
Fixes #164
Clippy and cargo warned me that
BlockId
andSignedBlock
are unused, so I removed them. Let's keep that in mind in case some stuff breaks in the future. All tests are passing atm 🥳You can find the details about the restructuring on the issue. Additionally, I also extracted
types
intotype.rs
Took me longer than expected, dependencies and imports were a mess 😅. I think this structure will be much better for the future.