Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime lib restructure #202

Merged
merged 23 commits into from
May 31, 2024
Merged

Runtime lib restructure #202

merged 23 commits into from
May 31, 2024

Conversation

ozgunozerk
Copy link
Collaborator

@ozgunozerk ozgunozerk commented May 22, 2024

Fixes #164

Clippy and cargo warned me that BlockId and SignedBlock are unused, so I removed them. Let's keep that in mind in case some stuff breaks in the future. All tests are passing atm 🥳

You can find the details about the restructuring on the issue. Additionally, I also extracted types into type.rs

Took me longer than expected, dependencies and imports were a mess 😅. I think this structure will be much better for the future.

@ozgunozerk ozgunozerk requested review from KitHat and 4meta5 May 22, 2024 15:11
@ozgunozerk ozgunozerk self-assigned this May 22, 2024
Copy link

netlify bot commented May 22, 2024

Deploy Preview for docs-oz-polkadot ready!

Name Link
🔨 Latest commit 1149da8
🔍 Latest deploy log https://app.netlify.com/sites/docs-oz-polkadot/deploys/6659ea085c43e600081ec414
😎 Deploy Preview https://deploy-preview-202--docs-oz-polkadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@4meta5 4meta5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to review closely as with any PR that moves configs between files, but I agree it's worth it for improved organization moving forward.

I think we should follow the same structure for the evm-template as well and it'd be easier to review those changes if they were included in this PR.

@ozgunozerk
Copy link
Collaborator Author

I think we should follow the same structure for the evm-template as well and it'd be easier to review those changes if they were included in this PR.

Only refactored generic one. Will refactor evm-template after @KitHat's PR's are merged.

If I refactor evm-template right now, there will be so many conflicts. As I mentioned, I think I have to wait for evm-template PR's to merge first

@4meta5 4meta5 added the priority: 0 Nice-to-have. Willing to ship without this. label May 26, 2024
@ozgunozerk ozgunozerk force-pushed the runtime-lib-restructure branch 2 times, most recently from f903b48 to d849f53 Compare May 29, 2024 12:25
@ozgunozerk ozgunozerk requested a review from 4meta5 May 29, 2024 18:12
@ozgunozerk ozgunozerk force-pushed the runtime-lib-restructure branch from 78f33a9 to 3237ba0 Compare May 30, 2024 10:17
Copy link
Member

@KitHat KitHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suspicious file, in other things LGTM!

@ozgunozerk ozgunozerk merged commit dc4f012 into main May 31, 2024
6 checks passed
@ozgunozerk ozgunozerk deleted the runtime-lib-restructure branch May 31, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: 0 Nice-to-have. Willing to ship without this.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

🎁 [Feature Request]: Organize runtime/src/lib.rs into smaller components.
3 participants