Precompiles #201
Merged
Precompiles #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Amar Singh <[email protected]>
✅ Deploy Preview for docs-oz-polkadot canceled.
|
ozgunozerk
reviewed
May 30, 2024
KitHat
reviewed
May 30, 2024
There was a problem hiding this comment.
LGTM!
A single question: don't we want to set a revert code to the precompile address like Moonbeam?
So nobody can send some funds to the address of precompile
https://github.com/moonbeam-foundation/moonbeam/blob/61647d84124c8e6d099176ce5ba357f821204864/node/service/src/chain_spec/moonbase.rs#L277
thanks, done in 44b54bc |
4meta5
commented
May 30, 2024
KitHat
approved these changes
May 31, 2024
ozgunozerk
approved these changes
May 31, 2024
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #193 to include the precompiles maintained in Frontier and included in the Frontier template