Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme and docs update for monorepo #183

Merged
merged 9 commits into from
May 27, 2024
Merged

readme and docs update for monorepo #183

merged 9 commits into from
May 27, 2024

Conversation

ozgunozerk
Copy link
Collaborator

Please review the changed content. If you think wordings can be improved or you want to add/change anything, we can do so in this PR.

@ozgunozerk ozgunozerk self-assigned this May 17, 2024
Copy link

netlify bot commented May 17, 2024

Deploy Preview for docs-oz-polkadot canceled.

Name Link
🔨 Latest commit 2100427
🔍 Latest deploy log https://app.netlify.com/sites/docs-oz-polkadot/deploys/665461dbe11f9500088a39e1

Copy link
Collaborator

@ggonzalez94 ggonzalez94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative to update the Readme. Left a few comments

ozgunozerk and others added 5 commits May 20, 2024 13:32
Co-authored-by: Gustavo Gonzalez <[email protected]>
Co-authored-by: Gustavo Gonzalez <[email protected]>
Co-authored-by: Gustavo Gonzalez <[email protected]>
Co-authored-by: Gustavo Gonzalez <[email protected]>
Copy link
Contributor

@4meta5 4meta5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should also update the repo description to express that this repo now contains plural templates instead of a singular template.

Co-authored-by: Amar Singh <[email protected]>
@ozgunozerk
Copy link
Collaborator Author

@4meta5 I couldn't see how to update repo description in settings. I'm not even sure if there is one tbh (I may be wrong). If there is one, and if you know how to do it, can you do it?

@ozgunozerk ozgunozerk merged commit 939c2cb into main May 27, 2024
@ozgunozerk ozgunozerk deleted the monorepo-readme branch May 27, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants