Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'environment' config option & add singletons setup #96

Merged
merged 17 commits into from
Nov 12, 2019

Conversation

nventuro
Copy link
Contributor

@nventuro nventuro commented Nov 8, 2019

This PR ended up being sort of involved :/ It does a number of things:

  • it renames the environment configuration option to contractAbstraction, since e.g. it may make sense to use truffle contracts in a non-truffle environment, unlike the old naming suggested
  • it upgrades to a newer version of contract-loader which is used by the singletons module, allowing for customization of the default sender and gas
  • it provides configuration options for the default sender and gas of contracts returned by singletons

@nventuro nventuro requested a review from frangio November 8, 2019 13:45
configure.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/config/singletons.js Outdated Show resolved Hide resolved
src/singletons.js Show resolved Hide resolved
@nventuro nventuro requested a review from frangio November 11, 2019 21:10
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the new subsections in Configuration.

README.md Outdated Show resolved Hide resolved
src/config/singletons.js Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@nventuro nventuro requested a review from frangio November 12, 2019 18:08
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nventuro nventuro merged commit 409e582 into OpenZeppelin:master Nov 12, 2019
@nventuro nventuro deleted the environment-rename branch November 12, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants