Make chai a dependency #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
force-pushed
the
chai-dependency
branch
from
f9edd98 to
8a674ae
Compare
frangio
force-pushed
the
chai-dependency
branch
from
3b0648d to
dc9236e
Compare
nventuro
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32, the longstanding issue that users have to install
chaiside by side withtest-helpersfor basically no reason.I made
chaia proper dependency as opposed to a peer dependency, and added code to installchai-bnfor the user if the version of the module they're using is different than ours.Would love to get this into 0.5 as soon as possible. 🙂