Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pass in custom arguments to shouldSupportInterfaces test helper #5350

Conversation

ernestognw
Copy link
Member

Motivation

These allows to reuse the shouldSupportInterfaces function in another context. One concrete example is that ERC-7802 requires ERC-165 in the community repository, where we can't test ERC-165 unless we copy paste the helpers or store the interface in this repository.

To avoid either, I think we should allow passing in more arguments to shouldSupportInterfaces so that the helper can be reused elsewhere.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Dec 8, 2024

⚠️ No Changeset found

Latest commit: f2a8f9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw ernestognw requested a review from Amxx December 9, 2024 21:34
@ernestognw ernestognw merged commit 1c1186a into OpenZeppelin:master Dec 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants