Migrate math tests to ethers.js v6 #4769
Conversation
|
test/helpers/iterate.js
Outdated
| const max = (...values) => values.slice(1).reduce((x, y) => (x > y ? x : y), values.at(0)); | ||
| const min = (...values) => values.slice(1).reduce((x, y) => (x < y ? x : y), values.at(0)); | ||
| const sum = (...values) => values.slice(1).reduce((x, y) => x + y, values.at(0)); |
There was a problem hiding this comment.
What do you think about keeping this in math.js and reexporting them here in ./iterate?
Alternative I'd propose getting rid of math.js, I just feel this is redundant.
There was a problem hiding this comment.
We could also put them in math.js, and remove them completelly (not reexport) from iterate.js.
There was a problem hiding this comment.
Yeah, let's put them in math.js makes sense to me. Also, just found out that this sum implementation returns undefined for an empty array. Not sure if we want that
Co-authored-by: Ernesto García <[email protected]>
PR Checklist
npx changeset add)