Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate address to ethersjs #4739

Merged
merged 14 commits into from
Nov 23, 2023
Merged

Migrate address to ethersjs #4739

merged 14 commits into from
Nov 23, 2023

Conversation

RenanSouza2
Copy link
Contributor

Opening this PR separetedly because of unknown errors on coverage test

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 879244d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Amxx
Amxx previously approved these changes Nov 22, 2023
View reviewed changes
@Amxx Amxx added this to the tests migration milestone Nov 22, 2023
Amxx
Amxx previously approved these changes Nov 22, 2023
View reviewed changes
ernestognw
ernestognw approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty neat, LGTM

@ernestognw ernestognw mentioned this pull request Nov 23, 2023
Closed
@ernestognw ernestognw merged commit bf75bcc into OpenZeppelin:master Nov 23, 2023
@RenanSouza2 RenanSouza2 deleted the migrate-address branch November 23, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw approved these changes

@Amxx Amxx Amxx left review comments

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
tests migration
Development

Successfully merging this pull request may close these issues.
3 participants
@RenanSouza2 @Amxx @ernestognw