Remove MultisigWallet in favor of gnosis/MultiSigWallet #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2017
frangio
changed the title
ProphetDaniel
pushed a commit
to classicdelta/Smart-Contracts
that referenced
this pull request
Mar 9, 2018
Remove MultisigWallet in favor of ConsenSys/MultiSigWallet
|
audit from open zepplin: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've decided to remove our own
MultisigWalletfrom OpenZeppelin.Our recommendation going forward is to use gnosis/MultiSigWallet. We have not performed a formal audit yet, but have informally reviewed the code in the past and consider it of excellent quality. We are aware that it has been through several audits, and will perform and publish our own soon.
This resolves the month-old issue #251, after a decision to prioritize it in light of last week's hack on the Parity multisig wallet.
Besides Gnosis' implementation being more tested and audited than our own, there was a function definition missing in our MultisigWallet which caused the contract to be abstract and thus impossible to deploy.