Improve ECDSA tests and docs #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
reviewed
Apr 6, 2021
| @@ -22,6 +22,10 @@ library ECDSA { | |||
| * recover to arbitrary addresses for non-hashed data. A safe way to ensure | |||
| * this is by receiving a hash of the original message (which may otherwise | |||
| * be too long), and then calling {toEthSignedMessageHash} on it. | |||
| * | |||
| * Documentation for signature generation: | |||
There was a problem hiding this comment.
It would be nicer to show the code inline here. "A client would generate signatures by using the signing methods in Web3.js or Ethers.js, as shown below:" ...
This comment has been minimized.
This comment has been minimized.
|
See also #1667. This PR should close that issue. |
frangio
changed the title
frangio
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2600
Fixes #2190
Fixes #1667
PR Checklist