Code

Fix/improve revert reason #1727#2018

Code

Merged

nventuro merged 24 commits intoOpenZeppelin:masterOpenZeppelin/openzeppelin-contracts:masterfrom alant:fix/improve-revert-reason-#1727alant/openzeppelin-solidity:fix/improve-revert-reason-#1727Copy head branch name to clipboardJan 23, 2020

+36-14

Commits

Commits on Dec 8, 2019

• adding mock contacts, test code

  alant

  committed
  839b6bf

  Copy full SHA for 839b6bf

• adding changes to ERC721.sol per @frangio's comments on original PR OpenZeppelin#1943

  alant

  committed
  bcb3125

  Copy full SHA for bcb3125

• fix solhint warnings

  alant

  committed
  2ee16ec

  Copy full SHA for 2ee16ec

Commits on Dec 10, 2019

• Update contracts/token/ERC721/ERC721.sol

  Show description for 027822d
  

  alant

  and

  frangio

  authored
  027822d

  Copy full SHA for 027822d

• same revert wording per @frangio's review suggestion

  alant

  committed
  07dcbd3

  Copy full SHA for 07dcbd3

• Merge branch 'fix/improve-revert-reason-#1727' of https://github.com/alant/openzeppelin-solidity into fix/improve-revert-reason-#1727

  alant

  committed
  1755395

  Copy full SHA for 1755395

• per @frangio's feedback, changing the inline assembly to accomplish: we want to ignore the first 4 bytes of content, so we should read the length and decrease it by 4, then take the memory location…

  Show description for be4d51d
  alant

  committed
  be4d51d

  Copy full SHA for be4d51d

Commits on Dec 11, 2019

• change revert msg assembly per PR comment by @frangio

  alant

  committed
  f0a90f6

  Copy full SHA for f0a90f6

• unify revert msg in test code

  alant

  committed
  ab1fb60

  Copy full SHA for ab1fb60

• Merge branch 'master' into fix/improve-revert-reason-#1727

  alant

  authored
  59cba42

  Copy full SHA for 59cba42

Commits on Dec 12, 2019

• fix some failed tests, wording change

  alant

  committed
  cd436a6

  Copy full SHA for cd436a6

Commits on Dec 13, 2019

• Update contracts/token/ERC721/ERC721.sol

  Show description for ee84cda
  

  alant

  and

  frangio

  authored
  ee84cda

  Copy full SHA for ee84cda

• Update contracts/token/ERC721/ERC721.sol

  Show description for 829032d
  

  alant

  and

  frangio

  authored
  829032d

  Copy full SHA for 829032d

• Merge branch 'fix/improve-revert-reason-#1727' of https://github.com/alant/openzeppelin-solidity into fix/improve-revert-reason-#1727

  alant

  committed
  f5a6a95

  Copy full SHA for f5a6a95

Commits on Dec 24, 2019

• fix test case, revert without reason

  alant

  committed
  1162b59

  Copy full SHA for 1162b59

Commits on Jan 7, 2020

• fix 'ERC721ReceiverRevertsMock: Transaction rejected by receiver'

  alant

  committed
  6aec945

  Copy full SHA for 6aec945

• Merge branch 'master' into fix/improve-revert-reason-#1727

  alant

  authored
  604f88b

  Copy full SHA for 604f88b

Commits on Jan 14, 2020

• style change per review by @frangio

  alant

  committed
  9668a49

  Copy full SHA for 9668a49

• Merge branch 'fix/improve-revert-reason-#1727' of https://github.com/alant/openzeppelin-solidity into fix/improve-revert-reason-#1727

  alant

  committed
  cf5c2b8

  Copy full SHA for cf5c2b8

• fix revert reason forwarding

  frangio

  authored
  f279bec

  Copy full SHA for f279bec

Commits on Jan 15, 2020

• remove duplicate contracts/mocks/ERC721ReceiverRevertsMock.sol per review https://github.com/OpenZeppelin/openzeppelin-contracts/pull/2018\#issuecomment-574381034

  alant

  committed
  6f33362

  Copy full SHA for 6f33362

Commits on Jan 23, 2020

• Add changelog entry

  nventuro

  committed
  4c2930d

  Copy full SHA for 4c2930d

• Fix tests

  nventuro

  committed
  2538e97

  Copy full SHA for 2538e97

• Make tests more clear

  nventuro

  committed
  f3e382a

  Copy full SHA for f3e382a