-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #1727: Improve revert reason when assuming interface compliance contracts. #1943
Closed
Closed
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3e2ad2d
Revert reason issue fixing
NoopurShinde 3f38430
Revert reason issue fixing
NoopurShinde 1ca3742
Merge branch 'master' of https://github.com/NoopurShinde/openzeppelin…
NoopurShinde 3d96ecf
Improve revert reason when assuming interface compliance #1727
NoopurShinde d210bae
Merge branch 'master' into master
NoopurShinde 486f8db
Fixed npm lint issues
NoopurShinde a625b8d
Fixed npm lint issues
NoopurShinde a58cd80
Fixed the ci/circleci: lint issue for solhint
NoopurShinde 4109cd6
Update package.json
NoopurShinde af1372d
Merge remote-tracking branch 'upstream/master'
NoopurShinde 06b34a0
Merge branch 'master' into master
NoopurShinde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Improve revert reason when assuming interface compliance #1727
- Loading branch information
commit 3d96ecfd5267a56cc67261c3c3f3d04fa2724806
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove these two variables since they're not used.