-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BurnableToken doesn't fire Transfer event #732
Comments
Is it a transfer though, it reads to me as a complete destruction of the burned token, rather than movement of it to a 0 address. |
I think it should have it! we had to change the burn method in the LifToken implementation to add the burn function. |
@rstormsf can you go ahead and create the PR? assign me as reviewer pls. |
4 tasks
@AugustoL done |
shrugs
pushed a commit
that referenced
this issue
Feb 20, 2018
ProphetDaniel
pushed a commit
to classicdelta/Smart-Contracts
that referenced
this issue
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🎉 Description
As a user, I'd expect that BurnableToken when called
burn(uint _value)
method, it should fireTransfer(msg.sender, address(0), value);
event.https://github.com/OpenZeppelin/zeppelin-solidity/blob/master/contracts/token/ERC20/BurnableToken.sol#L18
the same as MintableToken does when it fires
mint(to, value)
https://github.com/OpenZeppelin/zeppelin-solidity/blob/master/contracts/token/ERC20/MintableToken.sol#L35
Thoughts?
The text was updated successfully, but these errors were encountered: