-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Governor: Use smaller integers for timing parameters #3208
Comments
Hello @cygnusv, and thank you for raising that issue. I'll check what we can do, but please note that we want to move the |
Right, either way works 👍 |
Governor: Inconsistent types for voting timing parameters OpenZeppelin#3208 Changed time parameters to uint64 for consistency
fixed in #3224 |
Sorry folks the getters that return |
Following up on my previous comment. While the external getters should continue to return This is a breaking change that would be scheduled for 5.0. |
Some voting timing parameters are expressed as
uint256
, likevotingDelay
andvotingPeriod
inGovernorSettings
, while the newly introduceGovernorPreventLateQuorum
has avotingExtension
parameter with typeuint64
. These should be consistent.The text was updated successfully, but these errors were encountered: