-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC1155 module, dual and interface with Component implementation #852
Add ERC1155 module, dual and interface with Component implementation #852
Conversation
Hello @cloudvenger, thanks for all the work put into this. As this is scheduled as part of our upcoming milestone and since we're way past the original agreed deadline (~3rd week of November 2023, or December ~15th as the latest extension) we'll be picking this up internally to completion. Thanks again for your contributions. |
Juste reading your message @martriay |
Update error testing and remove tests failing from erc1155
To help to continue/finish the impl of ERC-1155 in component version, here is the list of what was done :
Remains to be done :
You can find a Smart Contract which used this erc1155 component version her : The Smart Contract is recognized as ERC-1155 on voyager blockchain explorer If you are any question, do not hesitate @martriay |
Superseded by #896 |
* Add ERC1155 module, dual and interface * Implement ERC1155 and update token_id variable names * Add ERC1155 receiver mocks and test dual1155 receiver * apply linter * Update token_uri variable and remove IERC1155MetadataCamelOnly support * Add ERC1155 mocks and tests and add ERC1155 preset * update CHANGELOG * adding PR number (#852) * reset changlog * Update ERC1155Component Event and add batch_burn * Add batch minting functions for ERC1155 tokens * Refactor code for better readability Update error testing and remove tests failing from erc1155 * feat: finish first version with 2.5.3 * feat: apply review updates * feat: add tests * feat: bump version and add entry to CHANGELOG * feat: add more tests * fix: remove print * feat: add preset tests * fix: format * feat: uncomment test * refactor: shortening test names * feat: move assertion * Update src/token/erc1155/erc1155.cairo Co-authored-by: Martín Triay <[email protected]> * fix: comments * featL apply review updates * feat: remove IAccount --------- Co-authored-by: Arn0d <[email protected]> Co-authored-by: Martín Triay <[email protected]>
* Add ERC1155 module, dual and interface * Implement ERC1155 and update token_id variable names * Add ERC1155 receiver mocks and test dual1155 receiver * apply linter * Update token_uri variable and remove IERC1155MetadataCamelOnly support * Add ERC1155 mocks and tests and add ERC1155 preset * update CHANGELOG * adding PR number (#852) * reset changlog * Update ERC1155Component Event and add batch_burn * Add batch minting functions for ERC1155 tokens * Refactor code for better readability Update error testing and remove tests failing from erc1155 * feat: finish first version with 2.5.3 * feat: apply review updates * feat: add tests * feat: bump version and add entry to CHANGELOG * feat: add more tests * fix: remove print * feat: add preset tests * fix: format * feat: uncomment test * refactor: shortening test names * feat: finish docs * fix: test * feat: move assertion * Update src/token/erc1155/erc1155.cairo Co-authored-by: Martín Triay <[email protected]> * fix: comments * featL apply review updates * Update docs/modules/ROOT/pages/erc1155.adoc Co-authored-by: Andrew Fleming <[email protected]> * Update docs/modules/ROOT/pages/erc1155.adoc Co-authored-by: Andrew Fleming <[email protected]> * Update docs/modules/ROOT/pages/api/erc1155.adoc Co-authored-by: Andrew Fleming <[email protected]> * docs: update * feat: apply review updates * feat: add sub-indexes * feat: remove IAccount * feat: apply review update * fix: merge conflicts * feat: apply review updates * feat: apply review updates * Update src/token/erc1155/erc1155.cairo Co-authored-by: Martín Triay <[email protected]> * Update docs/modules/ROOT/pages/erc1155.adoc Co-authored-by: Martín Triay <[email protected]> * Update docs/modules/ROOT/pages/erc1155.adoc Co-authored-by: Martín Triay <[email protected]> * fix: docs * feat: apply review updates * docs: add mixins link to common * feat: apply update reviews * fix: tests * Update docs/modules/ROOT/pages/api/erc1155.adoc Co-authored-by: Martín Triay <[email protected]> * Update docs/modules/ROOT/pages/api/erc1155.adoc Co-authored-by: Martín Triay <[email protected]> * Update docs/modules/ROOT/pages/api/erc1155.adoc Co-authored-by: Martín Triay <[email protected]> * Update docs/modules/ROOT/pages/api/erc1155.adoc Co-authored-by: Martín Triay <[email protected]> --------- Co-authored-by: Arn0d <[email protected]> Co-authored-by: Martín Triay <[email protected]> Co-authored-by: Andrew Fleming <[email protected]>
Fixes #572
PR Checklist