Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC1155 module, dual and interface with Component implementation #852

Closed
wants to merge 13 commits into from
Closed

Add ERC1155 module, dual and interface with Component implementation #852

wants to merge 13 commits into from

Conversation

cloudvenger
Copy link
Contributor

@cloudvenger cloudvenger commented Dec 12, 2023

Fixes #572

PR Checklist

  • Tests
  • Documentation
  • Added entry to CHANGELOG.md
  • Tried the feature on a public network

@martriay
Copy link
Contributor

martriay commented Jan 19, 2024

Hello @cloudvenger, thanks for all the work put into this. As this is scheduled as part of our upcoming milestone and since we're way past the original agreed deadline (~3rd week of November 2023, or December ~15th as the latest extension) we'll be picking this up internally to completion. Thanks again for your contributions.

@cloudvenger
Copy link
Contributor Author

Juste reading your message @martriay
I send you a Telegram message to explain myself on the subject and trying to find a solution to contribute

Update error testing and remove tests failing from erc1155
@cloudvenger
Copy link
Contributor Author

To help to continue/finish the impl of ERC-1155 in component version, here is the list of what was done :

  • Creation of erc1155 modul in src/token
  • Implementation of erc1155 Interface, Component, Receiver, Dual, Dual_receiver
  • Implementation of Preset for ERC-1155
  • Implementation of few unit tests for erc1155 component, receiver, dual & dual_receiver

Remains to be done :

  • Implementing much more unit tests to have a much better test coverage
  • Writing/Updating documentation for erc1155 component version

You can find a Smart Contract which used this erc1155 component version her :
https://testnet.starkscan.co/contract/0x01115205424b7d08d8895dd0d5c60d6f7beb5def65c749898d0864823f3dbb43#overview

The Smart Contract is recognized as ERC-1155 on voyager blockchain explorer
Important point : To be recognized as ERC-1155 Starkscan blockchain explorer, I needed to add the support interface of old ERC-1155 Interface 0xd9b67a26.
I did not add it in OpenZepplin erc-1155 impl but I add it in the constructor of the Smart Contract which used erc-1155 openzepplin component.

If you are any question, do not hesitate @martriay

@martriay
Copy link
Contributor

martriay commented Feb 9, 2024

Superseded by #896

@martriay martriay closed this Feb 9, 2024
ericnordelo added a commit that referenced this pull request Feb 29, 2024
* Add ERC1155 module, dual and interface

* Implement ERC1155 and update token_id variable names

* Add ERC1155 receiver mocks and test dual1155 receiver

* apply linter

* Update token_uri variable and remove IERC1155MetadataCamelOnly support

* Add ERC1155 mocks and tests and add ERC1155 preset

* update CHANGELOG

* adding PR number (#852)

* reset changlog

* Update ERC1155Component Event and add batch_burn

* Add batch minting functions for ERC1155 tokens

* Refactor code for better readability
Update error testing and remove tests failing from erc1155

* feat: finish first version with 2.5.3

* feat: apply review updates

* feat: add tests

* feat: bump version and add entry to CHANGELOG

* feat: add more tests

* fix: remove print

* feat: add preset tests

* fix: format

* feat: uncomment test

* refactor: shortening test names

* feat: move assertion

* Update src/token/erc1155/erc1155.cairo

Co-authored-by: Martín Triay <[email protected]>

* fix: comments

* featL apply review updates

* feat: remove IAccount

---------

Co-authored-by: Arn0d <[email protected]>
Co-authored-by: Martín Triay <[email protected]>
ericnordelo added a commit that referenced this pull request Mar 5, 2024
* Add ERC1155 module, dual and interface

* Implement ERC1155 and update token_id variable names

* Add ERC1155 receiver mocks and test dual1155 receiver

* apply linter

* Update token_uri variable and remove IERC1155MetadataCamelOnly support

* Add ERC1155 mocks and tests and add ERC1155 preset

* update CHANGELOG

* adding PR number (#852)

* reset changlog

* Update ERC1155Component Event and add batch_burn

* Add batch minting functions for ERC1155 tokens

* Refactor code for better readability
Update error testing and remove tests failing from erc1155

* feat: finish first version with 2.5.3

* feat: apply review updates

* feat: add tests

* feat: bump version and add entry to CHANGELOG

* feat: add more tests

* fix: remove print

* feat: add preset tests

* fix: format

* feat: uncomment test

* refactor: shortening test names

* feat: finish docs

* fix: test

* feat: move assertion

* Update src/token/erc1155/erc1155.cairo

Co-authored-by: Martín Triay <[email protected]>

* fix: comments

* featL apply review updates

* Update docs/modules/ROOT/pages/erc1155.adoc

Co-authored-by: Andrew Fleming <[email protected]>

* Update docs/modules/ROOT/pages/erc1155.adoc

Co-authored-by: Andrew Fleming <[email protected]>

* Update docs/modules/ROOT/pages/api/erc1155.adoc

Co-authored-by: Andrew Fleming <[email protected]>

* docs: update

* feat: apply review updates

* feat: add sub-indexes

* feat: remove IAccount

* feat: apply review update

* fix: merge conflicts

* feat: apply review updates

* feat: apply review updates

* Update src/token/erc1155/erc1155.cairo

Co-authored-by: Martín Triay <[email protected]>

* Update docs/modules/ROOT/pages/erc1155.adoc

Co-authored-by: Martín Triay <[email protected]>

* Update docs/modules/ROOT/pages/erc1155.adoc

Co-authored-by: Martín Triay <[email protected]>

* fix: docs

* feat: apply review updates

* docs: add mixins link to common

* feat: apply update reviews

* fix: tests

* Update docs/modules/ROOT/pages/api/erc1155.adoc

Co-authored-by: Martín Triay <[email protected]>

* Update docs/modules/ROOT/pages/api/erc1155.adoc

Co-authored-by: Martín Triay <[email protected]>

* Update docs/modules/ROOT/pages/api/erc1155.adoc

Co-authored-by: Martín Triay <[email protected]>

* Update docs/modules/ROOT/pages/api/erc1155.adoc

Co-authored-by: Martín Triay <[email protected]>

---------

Co-authored-by: Arn0d <[email protected]>
Co-authored-by: Martín Triay <[email protected]>
Co-authored-by: Andrew Fleming <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate erc1155 contracts
2 participants