Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multisig quorum issue (v1.0.0) #1315

Merged

Conversation

immrsd
Copy link
Collaborator

@immrsd immrsd commented Jan 22, 2025

Picks the Multisig quorum fix into the v1.0.0 release branch.

@immrsd immrsd self-assigned this Jan 22, 2025
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-v1.0.0@d493e25). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release-v1.0.0    #1315   +/-   ##
=================================================
  Coverage                  ?   95.22%           
=================================================
  Files                     ?       59           
  Lines                     ?     1488           
  Branches                  ?        0           
=================================================
  Hits                      ?     1417           
  Misses                    ?       71           
  Partials                  ?        0           
Files with missing lines Coverage Δ
packages/governance/src/multisig/multisig.cairo 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d493e25...795b88d. Read the comment docs.

Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@immrsd immrsd merged commit bc9b509 into OpenZeppelin:release-v1.0.0 Jan 22, 2025
4 checks passed
@ericnordelo ericnordelo linked an issue Jan 27, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Multisig quorum issue
3 participants