This repository has been archived by the owner on Feb 11, 2024. It is now read-only.
draft: support for backend list #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AIIX
commented
Dec 6, 2022
•
AIIX
commented
- Builds backend_list from a list of backend dicts
- GUI: Adds support to show 6 backends
- GUI: Adds icon for ovos and neon backends
- WIP
JarbasAl
reviewed
Dec 6, 2022
| {"backend_name": "No Backend", "backend_icon": "icons/nobackend.svg", "backend_type": "offline"}, | ||
| {"backend_name": "Personal Backend", "backend_icon": "icons/personal.svg", "backend_type": "personal"}, | ||
| {"backend_name": "OpenVoice Backend", "backend_icon": "icons/ovos.svg", "backend_type": "ovos"}, | ||
| {"backend_name": "Neon Backend", "backend_icon": "icons/neongecko.svg", "backend_type": "neon"}, |
There was a problem hiding this comment.
can we leave Neon commented out for now? its not fully implemented yet, should only be added after OpenVoiceOS/ovos-backend-client#11
There was a problem hiding this comment.
@NeonDaniel should this say Neon Backend, NeonGecko Backend or NeonGeckoCom Backend ?
|
also add the new icons to assets repo please |
JarbasAl
reviewed
Dec 6, 2022
| self.settings["backend_list"] = [ | ||
| {"backend_name": "No Backend", "backend_icon": "icons/nobackend.svg", "backend_type": "offline"}, | ||
| {"backend_name": "Personal Backend", "backend_icon": "icons/personal.svg", "backend_type": "personal"}, | ||
| {"backend_name": "OpenVoice Backend", "backend_icon": "icons/ovos.svg", "backend_type": "ovos"}, |
There was a problem hiding this comment.
For consistency i think this should say OpenVoiceOS Backend, we are using OVOS or OpenVoiceOS everywhere. just OpenVoice can be confusing since theres many projects using that wording for various different things
This was referenced Jan 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.