Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:oauth utils to ovos-utils and deprecate backend-client #301

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Nov 20, 2024

missed a commit in #299

Summary by CodeRabbit

  • New Features
    • Introduced functions to manage OAuth tokens, including automatic token refreshing.
  • Chores
    • Updated dependencies in the requirements file, re-adding timezonefinder and adding oauthlib.

Copy link
Contributor

coderabbitai bot commented Nov 20, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce two new functions in the ovos_utils/oauth.py file for managing OAuth tokens: refresh_oauth_token and get_oauth_token. These functions facilitate token retrieval and refreshing, ensuring that tokens are valid and updated as needed. Additionally, the requirements.txt file is updated to include the oauthlib dependency and re-add the previously removed timezonefinder dependency.

Changes

File Path Change Summary
ovos_utils/oauth.py Added functions refresh_oauth_token(token_id) and get_oauth_token(token_id, auto_refresh=True).
requirements/requirements.txt Added dependency oauthlib~=3.2 and re-added timezonefinder.

🐰 "In the code where tokens play,
New functions hop and save the day.
With refresh and get they dance,
Ensuring tokens take their chance.
Dependencies now in line,
With oauthlib and timezonefinder fine!" 🐇

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 42 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 68d7e28 and 99fb335.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 44.74%. Comparing base (0ec7ea5) to head (99fb335).
Report is 25 commits behind head on dev.

Files with missing lines Patch % Lines
ovos_utils/oauth.py 0.00% 39 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #301      +/-   ##
==========================================
- Coverage   47.19%   44.74%   -2.45%     
==========================================
  Files          31       33       +2     
  Lines        3244     3426     +182     
==========================================
+ Hits         1531     1533       +2     
- Misses       1713     1893     +180     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@JarbasAl JarbasAl merged commit a4f742c into dev Nov 20, 2024
9 of 10 checks passed
@JarbasAl JarbasAl deleted the more_oauth_utils branch November 20, 2024 12:12
@github-actions github-actions bot added feature and removed feature labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant