Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/ocp_stream_utils #257

Merged
merged 3 commits into from
Jun 21, 2024
Merged

feat/ocp_stream_utils #257

merged 3 commits into from
Jun 21, 2024

Conversation

JarbasAl
Copy link
Member

helper methods to parse the ocp stream from PluginStream objects

helper methods to parse the ocp stream from PluginStream objects
@JarbasAl JarbasAl added the enhancement New feature or request label Jun 21, 2024
JarbasAl added a commit to OpenVoiceOS/ovos-core that referenced this pull request Jun 21, 2024
handle Playlist objects

use helper methods to parse the ocp stream from PluginStream objects

needs OpenVoiceOS/ovos-utils#257
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 42.32%. Comparing base (b1519c4) to head (ad0c1ae).
Report is 5 commits behind head on dev.

Files Patch % Lines
ovos_utils/ocp.py 18.18% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #257      +/-   ##
==========================================
+ Coverage   41.89%   42.32%   +0.42%     
==========================================
  Files          31       31              
  Lines        3191     3213      +22     
==========================================
+ Hits         1337     1360      +23     
+ Misses       1854     1853       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit a05ab7b into dev Jun 21, 2024
9 checks passed
@JarbasAl JarbasAl deleted the feat/ocp_stream_utils branch June 21, 2024 17:20
JarbasAl added a commit to OpenVoiceOS/OVOS-workshop that referenced this pull request Jun 21, 2024
JarbasAl added a commit to OpenVoiceOS/OVOS-workshop that referenced this pull request Jun 21, 2024
JarbasAl added a commit to OpenVoiceOS/ovos-core that referenced this pull request Jun 21, 2024
* fix/legacy_play

handle Playlist objects

use helper methods to parse the ocp stream from PluginStream objects

needs OpenVoiceOS/ovos-utils#257

* Update requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant