Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backwards-compat imports with deprecation warnings #209

Merged
merged 4 commits into from
Dec 29, 2023

Conversation

NeonDaniel
Copy link
Member

Addresses failures: NeonGeckoCom/NeonCore#599

@NeonDaniel NeonDaniel requested a review from a team December 29, 2023 18:46
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 86 lines in your changes are missing coverage. Please review.

Comparison is base (f92fe7c) 38.63% compared to head (938e9a6) 48.15%.

❗ Current head 938e9a6 differs from pull request most recent head c313a25. Consider uploading reports for the commit c313a25 to get more accurate results

Files Patch % Lines
ovos_utils/sound.py 17.39% 57 Missing ⚠️
ovos_utils/skills.py 7.14% 13 Missing ⚠️
ovos_utils/messagebus.py 38.88% 11 Missing ⚠️
ovos_utils/version.py 0.00% 3 Missing ⚠️
ovos_utils/signal.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   38.63%   48.15%   +9.51%     
==========================================
  Files          78       28      -50     
  Lines        7283     2276    -5007     
==========================================
- Hits         2814     1096    -1718     
+ Misses       4469     1180    -3289     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl
Copy link
Member

dev branch already is on 0.1.0a1

last stable release should have all th deprecation warnings, this would need to be a manual post release

@NeonDaniel NeonDaniel changed the base branch from dev to master December 29, 2023 19:13
@NeonDaniel
Copy link
Member Author

dev branch already is on 0.1.0a1

last stable release should have all th deprecation warnings, this would need to be a manual post release

Rebased on master and manually specified a post version

* less deprecation warning logs

* restore EventContainer deprecation log
@JarbasAl JarbasAl merged commit 80a2f7c into master Dec 29, 2023
@JarbasAl JarbasAl deleted the FIX_BackwardsCompat branch December 29, 2023 19:47
emphasize pushed a commit to emphasize/ovos-utils that referenced this pull request Dec 30, 2023
* Add backwards-compat imports with deprecation warnings
NeonGeckoCom/NeonCore#599

* Fix `merge_dict` override

* Specify post release version

* 0.0.32post1 (OpenVoiceOS#210)

* less deprecation warning logs

* restore EventContainer deprecation log

---------

Co-authored-by: Daniel McKnight <[email protected]>
Co-authored-by: JarbasAI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants