Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LAST ALPHA #206

Merged
merged 4 commits into from
Dec 28, 2023
Merged

LAST ALPHA #206

merged 4 commits into from
Dec 28, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Dec 28, 2023 •
edited
Loading

closes #117

@JarbasAl JarbasAl added refactor code improvements with no functional changes packaging labels Dec 28, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 28, 2023 •
edited
Loading

Codecov Report

Attention: 1829 lines in your changes are missing coverage. Please review.

Comparison is base (f844113) 29.96% compared to head (da45af4) 31.95%.
Report is 2 commits behind head on dev.

Files Patch % Lines
ovos_utils/enclosure/mark1/faceplate/animations.py 0.00% 381 Missing ⚠️
...ls/enclosure/mark1/faceplate/cellular_automaton.py 0.00% 336 Missing ⚠️
ovos_utils/enclosure/mark1/eyes/__init__.py 0.00% 327 Missing ⚠️
ovos_utils/enclosure/mark1/faceplate/__init__.py 0.00% 271 Missing ⚠️
ovos_utils/skills/audioservice.py 2.75% 106 Missing ⚠️
ovos_utils/intents/layers.py 22.52% 86 Missing ⚠️
ovos_utils/enclosure/api.py 37.00% 80 Missing ⚠️
ovos_utils/intents/intent_service_interface.py 63.79% 63 Missing ⚠️
ovos_utils/skills/locations.py 6.77% 55 Missing ⚠️
ovos_utils/enclosure/mark1/faceplate/icons.py 0.00% 54 Missing ⚠️
... and 5 more
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #206      +/-   ##
==========================================
+ Coverage   29.96%   31.95%   +1.99%     
==========================================
  Files          49       49              
  Lines        6557     6524      -33     
==========================================
+ Hits         1965     2085     +120     
+ Misses       4592     4439     -153

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl marked this pull request as ready for review December 28, 2023 17:36
@JarbasAl JarbasAl changed the title refactor/bus_apis LAST ALPHA Dec 28, 2023
@JarbasAl JarbasAl marked this pull request as draft December 28, 2023 18:38
NeonDaniel
NeonDaniel requested changes Dec 28, 2023
View reviewed changes
Copy link
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay other than import errors failing unit tests

@JarbasAl JarbasAl mentioned this pull request Dec 28, 2023
Closed
15 tasks
@JarbasAl
deprecate skills
9594153 
deprecate intents

deprecate mk1

Update messagebus.py

Update audioservice.py

Update audioservice.py

Update layers.py

Update api.py

Update layers.py

Update api.py

Update api.py

Update audioservice.py

Update enclosure api.py
@JarbasAl JarbasAl force-pushed the refactor/move_bus_apis branch from 67cf587 to 9594153 Compare December 28, 2023 20:26
@JarbasAl JarbasAl marked this pull request as ready for review December 28, 2023 20:46
@JarbasAl JarbasAl merged commit 7e5e62b into dev Dec 28, 2023
10 checks passed
@JarbasAl JarbasAl deleted the refactor/move_bus_apis branch December 28, 2023 20:51
@github-actions github-actions bot mentioned this pull request Dec 28, 2023
Merged
emphasize pushed a commit to emphasize/ovos-utils that referenced this pull request Dec 30, 2023
@JarbasAl @emphasize
deprecation warnings for 0.1.0 (OpenVoiceOS#206)
62f15a2 
* deprecate skills

deprecate intents

deprecate mk1

Update messagebus.py

Update audioservice.py

Update audioservice.py

Update layers.py

Update api.py

Update layers.py

Update api.py

Update api.py

Update audioservice.py

Update enclosure api.py

* fix tests

* fix tests

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeonDaniel NeonDaniel NeonDaniel requested changes

Assignees
No one assigned
Labels
packaging refactor code improvements with no functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ROADMAP - ovos-utils 0.1.0
2 participants
@JarbasAl @NeonDaniel