Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstrings for FileWatcher class and add unit test coverage #152

Merged
merged 3 commits into from
May 31, 2023

Conversation

NeonDaniel
Copy link
Member

No description provided.

@NeonDaniel NeonDaniel requested a review from a team May 30, 2023 21:49
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #152 (659a50c) into dev (57f7909) will increase coverage by 10.72%.
The diff coverage is 25.70%.

@@            Coverage Diff             @@
##             dev     #152       +/-   ##
==========================================
+ Coverage   0.00%   10.72%   +10.72%     
==========================================
  Files         47       78       +31     
  Lines       5482     7086     +1604     
==========================================
+ Hits           0      760      +760     
- Misses      5482     6326      +844     
Impacted Files Coverage Δ
ovos_utils/__init__.py 0.00% <0.00%> (ø)
ovos_utils/bracket_expansion.py 0.00% <0.00%> (ø)
ovos_utils/configuration.py 0.00% <0.00%> (ø)
ovos_utils/device_input.py 0.00% <0.00%> (ø)
ovos_utils/dialog.py 0.00% <0.00%> (ø)
ovos_utils/enclosure/__init__.py 0.00% <0.00%> (ø)
ovos_utils/enclosure/api.py 0.00% <0.00%> (ø)
ovos_utils/events.py 0.00% <0.00%> (ø)
ovos_utils/file_utils.py 0.00% <0.00%> (ø)
ovos_utils/fingerprinting.py 0.00% <0.00%> (ø)
... and 56 more

@NeonDaniel NeonDaniel marked this pull request as draft May 31, 2023 15:54
Add filewatcher test case for reading changes on callback
@NeonDaniel NeonDaniel marked this pull request as ready for review May 31, 2023 16:07
@JarbasAl JarbasAl merged commit fe07c9a into OpenVoiceOS:dev May 31, 2023
@github-actions github-actions bot mentioned this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants