feat: singing #40
Merged
feat: singing #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the environment variable is set indicating OVOS is running in a container, pass the GitHub URL of the file to OCP instead of the local URL. Naturally only works if the assistant has an internet connection to GitHub.
JarbasAl
approved these changes
Jun 14, 2024
|
The skill doesn't always ask for confirmation and when it asked for confirmation, the |
this was an issue with STT, are you on latest dinkum that solves that issue with short words? and on latest ovos-config? (to see if instant_listen and remove_silence is on) |
I was running version |
0.3a43 is where it's fixed! But what do you mean it doesn't always ask for confirmation? |
|
@goldyfruit I can't replicate the issue you mentioned. If you have details on that please open up an issue and I'll put in a bugfix |
Merged
mikejgray
added a commit
that referenced
this pull request
Jul 18, 2024
* Increment Version * fix: correction to version.py * fix: release automation (#20) * fix: release automation * fix: setup looks for correct version * fix: adjust version location * Increment Version to * Update Changelog * chore: versioning * Increment Version to * Update Changelog * version * Increment Version to * Update Changelog * Increment Version to * fix: alpha release flow * Increment Version to 0.1.2a1 * Update Changelog * chore: Make README.md examples fit typical style (#22) The prior copy looked out of place in the rest of the homescreen examples, which are all capitalized and end in punctuation. * Update skill.json * more stt mistranscriptions for DukeNukemKeyword.voc (#26) * Increment Version to 0.1.2a2 * Update Changelog * update imports (#30) * update imports remove invalid license header, boilerplate copy paste from ancient times I'm the original author, in case of doubt the GPL license in header does not apply * Update skill.json --------- Co-authored-by: JarbasAl <[email protected]> * Increment Version to 0.1.2a3 * Update Changelog * chore: standardize naming, move files to locale dir (#32) * chore: standardize naming, move files to locale dir * Increment Version to 0.1.2a4 * Update Changelog * feat: portal ocp (#35) * tests * feat: glados mp3s to OCP playback * use OCP API, stub and start writing tests * Update skill.json * rename unit test file * broader coverage * syntax * remove 3.12 tests resolves ModuleNotFoundError: No module named 'setuptools' * remove errant todo * remove unsupported use case * remove confusing and unnecessary section from README * Update skill.json --------- Co-authored-by: mikejgray <[email protected]> * Increment Version to 0.1.2a5 * Update Changelog * feat: best in life (#34) * feat: what is best in life? * tests * add resources * drop explicit 3.7 support Since this isn't a default skill anywhere, users must install it explicitly, so maintaining support for EOL Python doesn't make a ton of sense. Plus it's making the tests fail. * Increment Version to 0.1.2a6 * Update Changelog * feat: malibu stacey and bill and ted easter eggs (#37) * feat: malibu stacey and bill and ted easter eggs Addresses #28 * bump minerva version to ovos-workshop compat * remove copyrighted sounds * Increment Version to 0.1.2a7 * Update Changelog * automations/translations * translations/allow_UNUSED_keywords * Increment Version to 0.1.2a8 * Update Changelog * Re-enable intent tests (#39) * Update skill.json * feat: singing (#40) * feat: singing skill port Closes #2 * feat: container support If the environment variable is set indicating OVOS is running in a container, pass the GitHub URL of the file to OCP instead of the local URL. Naturally only works if the assistant has an internet connection to GitHub. Co-authored-by: mikejgray <[email protected]> * Increment Version to 0.1.2a9 * Update Changelog * feat: make it snow (#33) * feat: snow on Christmas * Increment Version to 0.1.2a10 * Update Changelog * fix: laws of robotics (#43) * fix: laws of robotics Only one law at a time when requesting a specific law * Increment Version to 0.1.2a11 * Update Changelog * Increment Version to 1.0.0 --------- Co-authored-by: mikejgray <[email protected]> Co-authored-by: Mike Gray <[email protected]> Co-authored-by: AJ Jordan <[email protected]> Co-authored-by: JarbasAI <[email protected]> Co-authored-by: JarbasAl <[email protected]> Co-authored-by: miro <[email protected]> Co-authored-by: Daniel McKnight <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the voice is set to Alan Pope, whether via a Mimic plugin or Piper with alan-low or the default ovos-tts-plugin-server config, a request to sing will play the original Mimic voice songs from old Mycroft. If not, the assistant will say it's too shy to sing.
Also adds OCP/ovos-media compatibility for containerized environments. An internet connection to GitHub is required in that case, as the skill will send the GitHub raw file URL instead of the local file URL.
Closes #27
Closes #36