feat/sql_alchemy #51
feat/sql_alchemy #51
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #51 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 20
Lines ? 1664
Branches ? 0
=====================================
Hits ? 0
Misses ? 1664
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This comment was marked as resolved.
This comment was marked as resolved.
support multiple SQL engines Json database was good for prototyping but does not scale _________ Fix/table population (#52) _____________ 16MB per sample location data db from config mysql compat get_device get_device add/update_device Device.deserialize Device.serialize properties save_ww_recording save_stt_recording save_metric
JarbasAl
force-pushed
the
feat/sql_alchemy
branch
from
25ce9a2 to
0352ebb
Compare
There was a problem hiding this comment.
everything that I currently use in a backend seems to be working fine. Pairing new devices, weather api key, time format, location, geolocation, all work. I don't currently use oauth, so no real way to test it. I am just storing stuff in the default sqlite db. Have not tried to connect to my personal mysql db.
No errors that I have seen in the logs
|
ok, got cha, this is only handled in the table now (brought my own old config) |
| _mail_cfg.get("recipient") or \ | ||
| _mail_cfg.get("smtp", {}).get("username") | ||
|
|
||
| loc = location or _loc |
There was a problem hiding this comment.
this line does not work. location is not an empty dict so it never gets to _loc
There was a problem hiding this comment.
location['coordinate'] is the only one that throws an error, so I replaced with a check for that.
if not location["coordinate"]:
loc = _loc
else:
loc = location
then it worked. Not sure how else to handle this
There was a problem hiding this comment.
im not following, where is that coming from? we certainly dont want to partially read the default loc only, its all or nothing
is something passing an incomplete location here?
|
|
||
| add_ww_recording(uuid, | ||
| audio, | ||
| meta.get("name", "").replace("_", " "), |
There was a problem hiding this comment.
according to the backend-client
we have to access wake_word (or change it there)
A reason why i changed the variables, this is done numerous times back and forth. A debugging hell.
support multiple SQL engines
Json database was good for prototyping but does not scale
adopts the voice_config concept also defined here OpenVoiceOS/ovos-plugin-manager#131