Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 'Fake barge in' by default? #169

Closed
timonvanhasselt opened this issue Oct 8, 2024 · 5 comments
Closed

Enable 'Fake barge in' by default? #169

timonvanhasselt opened this issue Oct 8, 2024 · 5 comments
Assignees
Labels
question Further information is requested
Milestone

Comments

@timonvanhasselt
Copy link
Contributor

timonvanhasselt commented Oct 8, 2024

Based on a DM with @JarbasAl, maybe a consideration to enable "fake barge in" by default in the user mycroft.conf for RPi users and/or other setups with less quality microphones.

Background: I had a problem where my utterance was not picked up because of the audio/speech that was already playing (setup: PC with jabra speaker). Fake barge in solved that issue for me. I think it's a better UX with fake barge in enabled.

  "listener": {
     "fake_barge_in": true
@goldyfruit
Copy link
Member

Maybe this should be set by default in ovos-config rather than in the ovos-installer?

@goldyfruit goldyfruit self-assigned this Oct 8, 2024
@goldyfruit goldyfruit added the question Further information is requested label Oct 8, 2024
@goldyfruit goldyfruit added this to the Descent milestone Oct 8, 2024
@JarbasAl
Copy link
Member

JarbasAl commented Oct 8, 2024

i wouldnt want this by default other than in a rpi, and when mk2 drivers work there should be an exception as the sj201 does noise cancellation at hardware level

in more powerful systems a better experience would be to use something like https://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/Modules/#module-echo-cancel or RNNoise

i will give it some more thinking, but until then i think the installer should do it for rpi boards

@goldyfruit
Copy link
Member

mk2 drivers work there should be an exception as the sj201 does noise cancellation at hardware level

This doesn't work since kernel 5.x.

https://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/Modules/#module-echo-cancel

PulseAudio is replaced by PipeWire in most of the distributions. PipeWire is only installed and configured by the installer on Raspberry Pi boards as on laptops/PCs the user might have custom settings already configured.

@JarbasAl
Copy link
Member

JarbasAl commented Oct 8, 2024

wasnt suggesting the installer handle that, just showing what kind of alternatives i think make sense to fake barge in

i assume pipewire has an equivalent plugin?

@goldyfruit
Copy link
Member

i assume pipewire has an equivalent plugin?

Not that I'm aware off 😞

JarbasAl added a commit to OpenVoiceOS/ovos-config that referenced this issue Oct 8, 2024
JarbasAl added a commit to OpenVoiceOS/ovos-config that referenced this issue Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants