Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blacklisted skills #424

Merged
merged 4 commits into from
Mar 2, 2024
Merged

fix: blacklisted skills #424

merged 4 commits into from
Mar 2, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Feb 28, 2024

closes #383

missed in #313 apparently

logs should have

2024-02-28 22:01:00.559 - skills - ovos_core.skill_manager:_load_on_startup:540 - INFO - Loading offline skills...
2024-02-28 22:01:03.834 - skills - ovos_core.skill_manager:load_plugin_skills:334 - WARNING - skill-ovos-stop.openvoiceos is blacklisted, it will NOT be loaded
2024-02-28 22:01:03.834 - skills - ovos_core.skill_manager:load_plugin_skills:335 - INFO - Consider uninstalling skill-ovos-stop.openvoiceos instead of blacklisting it

@JarbasAl JarbasAl added the bug Something isn't working label Feb 28, 2024
@JarbasAl JarbasAl requested a review from goldyfruit February 28, 2024 22:03
@JarbasAl JarbasAl added this to the 0.0.8 milestone Feb 28, 2024
@JarbasAl JarbasAl requested a review from mikejgray February 28, 2024 22:04
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 63.85%. Comparing base (20689d1) to head (1088097).

Files Patch % Lines
ovos_core/skill_manager.py 25.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #424      +/-   ##
==========================================
- Coverage   64.12%   63.85%   -0.28%     
==========================================
  Files          15       15              
  Lines        2570     2584      +14     
==========================================
+ Hits         1648     1650       +2     
- Misses        922      934      +12     
Flag Coverage Δ
unittests 63.85% <25.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ovos_core/skill_manager.py Outdated Show resolved Hide resolved
@mikejgray
Copy link

Also some tests would be awesome here, so coverage doesn't drop while we're targeting 75% 🙂

@JarbasAl JarbasAl merged commit f0cd346 into dev Mar 2, 2024
3 of 4 checks passed
@JarbasAl JarbasAl deleted the fix/blacklisted_skills branch March 2, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to blacklist skills or change the fallback priority
2 participants