Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/stop_per_session #391

Merged
merged 2 commits into from
Jan 13, 2024

.

3e4d639
Select commit
Loading
Failed to load commit list.
Merged

feat/stop_per_session #391

.
3e4d639
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 13, 2024 in 1s

63.11% (+2.21%) compared to 835ac34

View this Pull Request on Codecov

63.11% (+2.21%) compared to 835ac34

Details

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (835ac34) 60.90% compared to head (3e4d639) 63.11%.
Report is 14 commits behind head on dev.

Files Patch % Lines
ovos_core/intent_services/commonqa_service.py 77.16% 29 Missing ⚠️
ovos_core/intent_services/stop_service.py 87.93% 14 Missing ⚠️
ovos_core/intent_services/padacioso_service.py 50.00% 6 Missing ⚠️
ovos_core/intent_services/adapt_service.py 60.00% 2 Missing ⚠️
ovos_core/intent_services/padatious_service.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #391      +/-   ##
==========================================
+ Coverage   60.90%   63.11%   +2.21%     
==========================================
  Files          13       14       +1     
  Lines        1857     2039     +182     
==========================================
+ Hits         1131     1287     +156     
- Misses        726      752      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.