feat/common_query service #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moves common query from a skill to a first class intent service instead of being the first fallback skill it is now called before fallback stage the common query skill only listened and emited events, it doesnt do "skill things", fits better as it's own intent matcher
Codecov Report
@@ Coverage Diff @@
## dev #127 +/- ##
==========================================
+ Coverage 50.35% 52.94% +2.59%
==========================================
Files 119 150 +31
Lines 10077 9176 -901
==========================================
- Hits 5074 4858 -216
+ Misses 5003 4318 -685
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves common query from a skill to a first class intent service
instead of being the first fallback skill it is now called before fallback stage
the common query skill only listened and emited events, it doesnt do "skill things", fits better as it's own intent matcher
deprecates https://github.com/OpenVoiceOS/skill-ovos-common-query , it should be archived but can still be used in unittests and in regular mycroft
other misc fixes:
get_message_lang, code was duplicated in several places- feat/lang_utils ovos-utils#47
- Fix/full lang ovos-utils#48