Init fix, logging updates, and unit tests #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #45 +/- ##
==========================================
+ Coverage 47.15% 49.11% +1.95%
==========================================
Files 14 14
Lines 1179 1189 +10
==========================================
+ Hits 556 584 +28
+ Misses 623 605 -18
|
…erence Ensure stopping event is cleared on thread start Add unit test coverage for scheduler init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logging around scheduler lifecycle and any exceptions
Add logging around event scheduling and potential errors
Fix potential init bug
Add unit test coverage for Scheduler init