Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:fakebus support #7

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix:fakebus support #7

merged 2 commits into from
Oct 30, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Oct 30, 2024

FakeBus usage does not use a real event loop and would cause MPV to always timeout, this manifests under hivemind satellites

Summary by CodeRabbit

  • New Features

    • Integrated support for FakeBus to enhance playback handling.
    • Introduced automated workflows for publishing stable releases and managing dependencies with Dependabot.
    • Added a new workflow for automatic labeling of pull requests based on conventional standards.
    • Implemented a new workflow for automating the release process upon merging pull requests.
  • Bug Fixes

    • Improved control flow to prevent unnecessary timeout messages when using FakeBus.
  • Chores

    • Removed outdated workflows for publishing alpha, minor, major, and build releases.
    • Added new workflows for stable release management.

FakeBus usage does not use a real event loop and would cause MPV to always timeout, this manifests under hivemind satellites
Copy link

coderabbitai bot commented Oct 30, 2024

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 34 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 49d8647 and f582915.

Walkthrough

The changes introduce a new import statement for FakeBus in the ovos_plugin_mpv/__init__.py file. A conditional check is added in the handle_track_eof_status method to determine if the bus instance is of type FakeBus. If it is not, the method will emit a message to check for playback timeout, thereby modifying the control flow to avoid emitting this message when using FakeBus. The overall structure and functionality of the OVOSMPVService class remain unchanged.

Changes

File Path Change Summary
ovos_plugin_mpv/init.py Added import for FakeBus and modified handle_track_eof_status to check bus type before emitting timeout message.
.github/dependabot.yml Created new Dependabot configuration file for managing Python package updates.
.github/workflows/conventional-label.yaml Added new GitHub Actions workflow for automatic labeling of pull requests based on conventional standards.
.github/workflows/publish_stable.yml Introduced a new workflow for automating the stable release process of the project.
.github/workflows/release_workflow.yml Added a new workflow for automating the release process triggered by merging pull requests.
.github/workflows/dev2master.yml Deleted workflow for merging changes from dev to master.
.github/workflows/publish_alpha.yml Deleted workflow for publishing alpha builds to Test PyPI.
.github/workflows/publish_build.yml Deleted workflow for generating and publishing distribution packages to PyPI.
.github/workflows/publish_major.yml Deleted workflow for publishing major releases to PyPI.
.github/workflows/publish_minor.yml Deleted workflow for publishing minor releases to PyPI.
.github/workflows/unit_tests.yml Deleted workflow for running unit tests across multiple Python versions.
scripts/bump_alpha.py Deleted script for incrementing the alpha version number.
scripts/bump_build.py Deleted script for incrementing the build version number.
scripts/bump_major.py Deleted script for incrementing the major version number.
scripts/bump_minor.py Deleted script for incrementing the minor version number.
scripts/remove_alpha.py Deleted script for resetting the alpha version number.

Possibly related PRs

  • fix:fakebus support #7: The changes in this PR directly relate to the main PR as both involve the addition of the FakeBus import and modifications to the handle_track_eof_status method to accommodate the behavior of FakeBus.

Suggested labels

bug

Poem

In the land of hops and play,
A bus named Fake joins the fray.
With checks in place, we dance and sing,
No timeout woes when it’s spring!
So let us cheer, with ears so bright,
For smoother tunes in the moonlight! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@JarbasAl JarbasAl merged commit fe9abc6 into dev Oct 30, 2024
1 check passed
@JarbasAl JarbasAl deleted the fix/fakebus branch October 30, 2024 16:35
@github-actions github-actions bot added fix and removed fix labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant