-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: respect assist #38
Conversation
Home Assistant now allows you to explicitly expose entities to specific voice assistants. This feature will respect that setting by default.
141dec1
to
82dca59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the default HomeAssistant behavior documented somewhere (maybe worth a note or link in the README)? I will do some testing to make sure the default behavior works as expected
I would really like to get this feature landed, my HA has so many entities it bogs down my OVOS instance. Is there any work on this PR that needs doing? I'll give it a test locally |
We're just waiting on some testing. I've run it at home and it seems to work but looking for independent confirmation. Please let me know how this branch works for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and seems to be working well for me ignoring devices that I disabled assist for.
On a side-note, it does match devices that are unavailable but I'm not sure if there's a way to handle that and it really is an edge case (I added my lights to a generic Zigbee hub and disabled the Hue integration but have not yet removed it).
Opened an issue
Home Assistant now allows you to explicitly expose entities to specific voice assistants.
This feature will respect that setting by default.
Addresses #37