Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect assist #38

Merged
merged 7 commits into from
Sep 28, 2023
Merged

feat: respect assist #38

merged 7 commits into from
Sep 28, 2023

Conversation

mikejgray
Copy link
Collaborator

Home Assistant now allows you to explicitly expose entities to specific voice assistants.

This feature will respect that setting by default.

Addresses #37

@mikejgray mikejgray self-assigned this Jul 24, 2023
Home Assistant now allows you to explicitly expose entities to specific voice assistants.

This feature will respect that setting by default.
@mikejgray mikejgray force-pushed the FEAT_RespectAssist branch from 141dec1 to 82dca59 Compare July 24, 2023 03:52
@mikejgray mikejgray requested a review from NeonDaniel July 24, 2023 03:53
Copy link
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the default HomeAssistant behavior documented somewhere (maybe worth a note or link in the README)? I will do some testing to make sure the default behavior works as expected

README.md Show resolved Hide resolved
@mikejgray mikejgray requested a review from NeonDaniel September 2, 2023 15:07
@Ramblurr
Copy link

I would really like to get this feature landed, my HA has so many entities it bogs down my OVOS instance.

Is there any work on this PR that needs doing? I'll give it a test locally

@mikejgray
Copy link
Collaborator Author

I would really like to get this feature landed, my HA has so many entities it bogs down my OVOS instance.

Is there any work on this PR that needs doing? I'll give it a test locally

We're just waiting on some testing. I've run it at home and it seems to work but looking for independent confirmation. Please let me know how this branch works for you.

@NeonDaniel NeonDaniel changed the base branch from master to dev September 26, 2023 16:43
Copy link
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to be working well for me ignoring devices that I disabled assist for.

On a side-note, it does match devices that are unavailable but I'm not sure if there's a way to handle that and it really is an edge case (I added my lights to a generic Zigbee hub and disabled the Hue integration but have not yet removed it).

Opened an issue

@mikejgray mikejgray merged commit abbf7e3 into dev Sep 28, 2023
@mikejgray mikejgray deleted the FEAT_RespectAssist branch September 28, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants