Switch wsconnector to internal socket client #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AIIX
commented
Jan 12, 2023
•
AIIX
commented
- Introduces a custom socket asynchronous HomeAssistantClient that replaces HASS client implementation with minimal changes on connector side
- Fixes all bugs and errors encountered with using the HASS Client
- Removes the "use_websocket" config key as this is already discovered at runtime on instance setup and on startup for already configured instances
- Moves all debug behind a "enable_debug" configuration flag to keep the PHAL client logs clean
NeonDaniel
reviewed
Jan 14, 2023
There was a problem hiding this comment.
Skimmed changes and the look good, couple bugs from testing (local wss connection):
- After turning off a device on or off in the UI, the new state isn't displayed until I go to a different view and come back (only noticed in grouped view, appeared to work in devices view)
Other less important notes:
- Camera previews work, but playback does not
- When I display grouped, the bottom bar is all
..., could this be made scrollable? - All of my rooms have
sappended (i.e. "Hallways", "Kitchens", "Downstairss"
|
This PR additionally now adds support for QR Code based oauth authentication for quicker setups. Additionally bugs mentioned above in the initial review have also now been fixed |
NeonDaniel
requested changes
Jan 20, 2023
NeonDaniel
requested changes
Jan 24, 2023
requirements.txt
Outdated
| @@ -1,7 +1,7 @@ | |||
| ovos-plugin-manager>=0.0.1 | |||
| ovos-utils~=0.0.27a3 | |||
| ovos-utils~=0.0, >=0.0.28 | |||
There was a problem hiding this comment.
there is no 0.0.28 release, this should probably be ovos-utils~=0.0.27?
NeonDaniel
approved these changes
Jan 24, 2023
| @@ -1,7 +1,7 @@ | |||
| ovos-plugin-manager>=0.0.1 | |||
| ovos-utils~=0.0.27a3 | |||
| ovos-utils>=0.0.27 | |||
There was a problem hiding this comment.
This could probably be ~=0.0.27 to prevent updating to an incompatible release (i.e. 1.0.0) in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.