Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise and handle an exception if qr_code_url is not generated #49

Closed
mikejgray opened this issue Jan 9, 2024 · 3 comments
Closed

Raise and handle an exception if qr_code_url is not generated #49

mikejgray opened this issue Jan 9, 2024 · 3 comments
Assignees

Comments

@mikejgray
Copy link
Collaborator

          Nothing is displayed; it probably would be worth raising an exception if we handled those exceptions and present them to the user somehow

Originally posted by @NeonDaniel in #48 (comment)

@NeonDaniel
Copy link
Member

NeonDaniel commented Jan 9, 2024

Not sure how we want to manage this, but some ideas:

  • Speak an error message in the plugin; not sure how actionable it could be but better than quietly failing with a blank screen
  • Show an error message and return to the home screen?
  • Requires more planning and related work, but we could define some message to emit for exceptions that can't be handled nicely; the support helper skill or some plugin could then decide to send an email or log to some specific path for debugging

@mikejgray
Copy link
Collaborator Author

Do we have any existing examples of plugins speaking? That's usually reserved for skills but easy enough to make happen with a bus message. Curious if we can follow an existing pattern

@NeonDaniel
Copy link
Member

Do we have any existing examples of plugins speaking? That's usually reserved for skills but easy enough to make happen with a bus message. Curious if we can follow an existing pattern

Not that I know of; I guess other plugins usually just display a gui page without any audio (i.e. network connection failure)

@mikejgray mikejgray self-assigned this Jan 25, 2025
mikejgray added a commit that referenced this issue Jan 25, 2025
If the QR code is not successfully generated, send the user a notification. A notification is chosen for persistence, otherwise text on the screen may be lost on boot.

Closes #49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants