Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/decouple from mycroft #21

Merged

Conversation

NeonJarbas
Copy link
Contributor

ensures ovos_workshop can be used without mycroft unless explicitly importing skills module

  • decorators were causing cyclic imports
  • OvosAbstractApp is meant to run in non-mycroft systems where the import is not available

JarbasAl added 3 commits May 31, 2022 17:58
being in the skills module was causing cyclic imports due to helper skill classes importing mycroft
@JarbasAl JarbasAl added bug Something isn't working refactor code improvements with no functional changes labels Jun 2, 2022
@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

❗ No coverage uploaded for pull request base (dev@9177788). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev     #21   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      25           
  Lines          ?    1448           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?    1448           
  Partials       ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9177788...9636de4. Read the comment docs.

@JarbasAl JarbasAl merged commit 9ca2018 into OpenVoiceOS:dev Jun 2, 2022
@github-actions github-actions bot mentioned this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor code improvements with no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants