Fix re-adding to Chandler-group (#938)

OpenVK · Nov 14, 2023 · dcf3631 · dcf3631
1 parent 71c5902
commit dcf3631
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/Web/Models/Repositories/ChandlerGroups.php b/Web/Models/Repositories/ChandlerGroups.php
@@ -45,4 +45,9 @@ function getPermissionsById(string $UUID): \Traversable
     {
         foreach($this->perms->where("group", $UUID) as $perm) yield $perm;
     }
+
+    function isUserAMember(string $GID, string $UID): bool
+    {
+        return ($this->context->query("SELECT * FROM `ChandlerACLRelations` WHERE `group` = ? AND `user` = ?", $GID, $UID)) !== NULL;
+    }
 }
diff --git a/Web/Presenters/AdminPresenter.php b/Web/Presenters/AdminPresenter.php
@@ -110,8 +110,10 @@ function renderUser(int $id): void
                 if($user->onlineStatus() != $this->postParam("online")) $user->setOnline(intval($this->postParam("online")));
                 $user->setVerified(empty($this->postParam("verify") ? 0 : 1));
                 if($this->postParam("add-to-group")) {
-                    $query = "INSERT INTO `ChandlerACLRelations` (`user`, `group`) VALUES ('" . $user->getChandlerGUID() . "', '" . $this->postParam("add-to-group") . "')";
-                    DatabaseConnection::i()->getConnection()->query($query);
+                    if (!(new ChandlerGroups)->isUserAMember($user->getChandlerGUID(), $this->postParam("add-to-group"))) {
+                        $query = "INSERT INTO `ChandlerACLRelations` (`user`, `group`) VALUES ('" . $user->getChandlerGUID() . "', '" . $this->postParam("add-to-group") . "')";
+                        DatabaseConnection::i()->getConnection()->query($query);
+                    }
                 }
                 if($this->postParam("password")) {
                     $user->getChandlerUser()->updatePassword($this->postParam("password"));