displaying choropleth from the rich data panel #315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use either the local server or the actual one (once the changes are in place) to test this out. removed the hard-coded values. also removed and changed code that will need to be updated as well, as we're now using the new data format for the population of the data mapper as well there is some work left for making sure when a geography changes that the data is properly used removed the on-the-fly getting of the indicator data for now until the BE is ready. the data is available in the all_details request anyway for now but this will change in the future
… on_the_fly_choropleth_data # Conflicts: # server.js
slightly adjust the subindicator to not pass too many variables along that only change once and can be saved to the class
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
|
||
| let result = bt.calculate({ data, subindicatorArr }) | ||
| const CHILD_DATA = { | ||
| EC: [{ |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| gender: "Female", | ||
| language: "English" | ||
| }], | ||
| FS: [{ |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Deploy preview for wazimap-staging ready! Built with commit c4a3c16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Displaying choropleth of a subindicator on a chart on the rich data panel
Related Issue
#281
How to test it locally
Screenshots
Changelog
Added
Updated
Removed
Checklist
Pull Request
Code Quality
Testing