Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show blog post cover image on the main site #424

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

moteanup24
Copy link
Contributor

@moteanup24 moteanup24 commented Mar 18, 2025

Open for comments/requests!

Build preview:

Screenshot at 2025-03-18 00-28-02

Copy link

vercel bot commented Mar 18, 2025

@moteanup24 is attempting to deploy a commit to the OpenSats Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Mar 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
os-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 2:11pm

@dergigi
Copy link
Member

dergigi commented Mar 18, 2025

Awesome, thank you 🙏 Looks great already!

Can we try to see how it would look like if we made the image a little bigger and move the date "inside" the image, and make the text of the date white?

@moteanup24
Copy link
Contributor Author

ok! here's how it looks now--

Screenshot at 2025-03-18 23-38-57

@dergigi
Copy link
Member

dergigi commented Mar 19, 2025

Nice! I like that.

Can we try moving the date down a little bit (so that it aligns with the title) and to the right a little (so that it aligns with the logo)?

Screenshot_20250319-113111.png

Would love to hear some other opinions in terms of how it looks @BoltTouring @Arvin21M

@moteanup24
Copy link
Contributor Author

no problem! latest looks like this:
Screenshot at 2025-03-19 09-32-50

@Arvin21M
Copy link
Contributor

Arvin21M commented Mar 19, 2025

Would love to hear some other opinions in terms of how it looks...

Re: Date On Image

  • I think it looks really good.
  • It will be harder to see the date for images that are lightly colored in the top left area.
    • In such cases or perhaps across the board, a 0 to low transparency for the date might be the fix.

Re: Incorporating The Header Image

  • I really like this.
  • Breaks up all the text with something visually appealing (eye candy).
  • I can be swayed either way, but image feels large in comparison the text to the right, however considering the aspect ratio we use, adjusting the size down may look too small.
  • Will anything happen when the image is clicked (open the post in a new tab, open the image in new tab, something else)?

TLDR:

  • Once adjustment of date placement from Gigi's feedback is addressed, if nothing else changes, I'd be very happy with this.

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants