-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cnh/intregate UI core from npm #7162
Conversation
cbf2389
to
bce3397
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, I spotted some bugs:
-
display is broken if I click on the arrow next to the eye in the scenario page 👁️
-
the display of the simulation parameters is not correct, same for the import tab and the stdcm page
-
the rolling stock image is very small in the rolling stock selector
-
the popover to select the data layer is also broken in the main map
bce3397
to
e2dd555
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7162 +/- ##
============================================
- Coverage 28.73% 28.73% -0.01%
Complexity 2004 2004
============================================
Files 1123 1123
Lines 138057 138057
Branches 2684 2684
============================================
- Hits 39670 39668 -2
- Misses 96790 96792 +2
Partials 1597 1597
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e2dd555
to
f715157
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interface is perfect now, thanks, I only noticed that the input does not seem to work and you forgot a new line 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅ You can merge after you have done these few things:
- fix the missing new line
- remove the commit which test the new input component
The bugs related to the input will be fixed later in osrd-ui
37e398b
to
5a14c17
Compare
front: fix forgotten img front: fix notification buttons on map editor
5a14c17
to
88e8376
Compare
Testing the integration of ui-core into osrd/front.
To handle the integration properly, we need to reset some styles. This is due to the base style of Tailwind that comes with ui-core, which sets the default style for these HTML elements. In particular :
the display of img and svg is set to display:block, which positions them above or below their sibling elements. (issue reported here).
the height of the img is set to auto, which causes the img to take up all the available space of the parent element even if you define a height in the style (issue reported here).
The button has a background-color transparent as mentionned here