Update kvm.rb to fix localization bug #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LANG environment variable does not work as expected with virsh -c qemu:///system nodeinfo. But LC_ALL=C works fine. Without LC_ALL=C monitoring fails with a "Error monitoring Host hostname (0): ./kvm.rb:49: undefined method `*' for nil:NilClass (NoMethodError)". Server configuration: OS: CentOS 6.2 OpenNebula: 4.14.2 Default language: ru_RU.UTF-8 Bug example: LANG=C virsh -c qemu:///system nodeinfo Модель процессора: x86_64 CPU: 16 Частота процессора: 1600 MHz Сокеты: 1 Ядер на сокет: 4 Потоков на ядро: 2 Ячейки NUMA: 2 Объём памяти: 74237932 KiB Correct behavior: LC_ALL=C virsh -c qemu:///system nodeinfo CPU model: x86_64 CPU(s): 16 CPU frequency: 1600 MHz CPU socket(s): 1 Core(s) per socket: 4 Thread(s) per core: 2 NUMA cell(s): 2 Memory size: 74237932 KiB
|
thanks!! |
rsmontero
pushed a commit
that referenced
this pull request
Jul 23, 2020
rsmontero
pushed a commit
that referenced
this pull request
Oct 6, 2020
(cherry picked from commit c92c8a8)
rsmontero
pushed a commit
that referenced
this pull request
Jan 20, 2021
rsmontero
pushed a commit
that referenced
this pull request
Apr 13, 2021
(cherry picked from commit c92c8a8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LANG environment variable does not work as expected with virsh -c qemu:///system nodeinfo. But LC_ALL=C works fine.
Without LC_ALL=C monitoring fails with a "Error monitoring Host hostname (0): ./kvm.rb:49: undefined method `*' for nil:NilClass (NoMethodError)".
Server configuration:
OS: CentOS 6.2
OpenNebula: 4.14.2
Default language: ru_RU.UTF-8
Bug example:
LANG=C virsh -c qemu:///system nodeinfo
Модель процессора: x86_64
CPU: 16
Частота процессора: 1600 MHz
Сокеты: 1
Ядер на сокет: 4
Потоков на ядро: 2
Ячейки NUMA: 2
Объём памяти: 74237932 KiB
Correct behavior:
LC_ALL=C virsh -c qemu:///system nodeinfo
CPU model: x86_64
CPU(s): 16
CPU frequency: 1600 MHz
CPU socket(s): 1
Core(s) per socket: 4
Thread(s) per core: 2
NUMA cell(s): 2
Memory size: 74237932 KiB