Proposal: changing lvremove behavior #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Pedro Thanks for this !!!! we are going to merge this together with your contribution to get rid of cLVM in pull request #72 Cheers |
|
Nice PR, this fix my problem related to Instance remove process when using fs_lvm. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. The OpenNebula Dev Team |
|
Seems this is no longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROPOSAL:
lvremove -f can lead to race conditions at udev making all the lvm commands to hang indefinitely.
Nowadays lvm defaults to retry_deactivation = 1 at lvm.conf, which lvremove uses and theoretically should mitigate this.
However I recently had issues even with retry_deactivation.
Probably a safer bet is to deactivate the volume before removing it, if the deactivation fails the removal process should fail.
This way even if the -f behavior change in the future we will be OK.
In OpenNebula's lvm use case this shouldn't have side effects, however feedback is needed on this.