B #1710: fix bug when parent_id is empty #3405
Merged
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsmontero
approved these changes
Jun 5, 2019
screenlock
reviewed
Aug 19, 2019
| if !parent_id.nil? | ||
| vnet_usage[parent_id] = 0 if vnet_usage[parent_id].nil? | ||
| vnet_usage[parent_id] += size | ||
| next if parent_id.nil? || parent_id.empty? |
There was a problem hiding this comment.
Is it correct ? Pass if its nil or empty, better is not (nil or empty)
478 next if !(parent_id.nil? || parent_id.empty?)
i think
rsmontero
pushed a commit
that referenced
this pull request
Feb 4, 2025
Signed-off-by: Ángel Cívico Martos <[email protected]>
rsmontero
pushed a commit
that referenced
this pull request
Feb 4, 2025
Signed-off-by: Ángel Cívico Martos <[email protected]> (cherry picked from commit 8384884)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to 5.8 and master.