B #1841 Improve error message when Import Wild or VM Template with disks without back reference #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… without back reference
tinova
reviewed
Mar 12, 2018
| @@ -249,10 +249,22 @@ def import_vcenter_disks(vc_uuid, dpool, ipool, type, sunstone=false) | |||
| allocated_images = [] | |||
|
|
|||
| vc_disks.each do |disk| | |||
| datastore_found = VCenterDriver::Storage.get_one_image_ds_by_ref_and_dc(disk[:datastore]._ref, | |||
|
|
|||
There was a problem hiding this comment.
code looks good, just a style comment, please do not use so many empty lines. for instance, the begin rescue block should look:
begin
ds_ref = disk[:datastore]._ref
rescue
raise "The ISO #{disk[:path_wo_ds].name} cannot be found because the datastore was removed or deleted"
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply 5.6