Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify live memory resize for KVM #5753

Closed
4 of 7 tasks
paczerny opened this issue Feb 28, 2022 · 6 comments
Closed
4 of 7 tasks

Simplify live memory resize for KVM #5753

paczerny opened this issue Feb 28, 2022 · 6 comments
Assignees
@FrederickBor
Labels
Category: Sunstone Priority: Normal Sponsored Status: Accepted Type: Feature
Milestone
Release 6.6

Comments

@paczerny
Copy link
Member

paczerny commented Feb 28, 2022 •
edited by FrederickBor
Loading

Description
The live memory resize was implemented in #1660 , using virsh attach-device described here. But this implementation has a lot of limitations, especially for removing the memory.
To remove the limitation, use virsh setmem as described here

Use case
Easier live memory resizing for kvm

Interface Changes
None.

Additional Context
New implementation doesn't need the MEMORY_SLOTS attribute

I haven't find which QEMU version is needed for this implementation

Progress Status

  • Branch created
  • Code committed to development branch
  • Sunstone Testing - QA
  • Documentation
  • Release notes - resolved issues, compatibility, known issues
  • Code committed to upstream release/hotfix branches
  • Documentation committed to upstream release/hotfix branches
@paczerny paczerny added this to the Release 6.2.2 milestone Feb 28, 2022
@paczerny paczerny self-assigned this Feb 28, 2022
@paczerny paczerny changed the title Simiplify live memory resize for KVM Simplify live memory resize for KVM Feb 28, 2022
@paczerny
Copy link
Member Author

paczerny commented Mar 1, 2022

PRs:

rsmontero pushed a commit that referenced this issue Mar 3, 2022
@rsmontero
F #5753: Better live mem resize for KVM (#1820)
d787313 
(cherry picked from commit c6965c3)
@rsmontero
Copy link
Member

There are some valid use cases for the hotplug method (e.g. PCI passtrhough devices to allow DMA, improved support across guest OS...).

This feature is to include a MEMORY_RESIZE_MODE:

  • balloon the actual implementation
  • hotplug the previous one

@rsmontero rsmontero reopened this Oct 10, 2022
@rsmontero rsmontero modified the milestones: Release 6.2.2, Release 6.6 Oct 10, 2022
@paczerny
Copy link
Member Author

paczerny commented Nov 8, 2022 •
edited
Loading

Two options for memory resize implemented, PRs:

paczerny pushed a commit to OpenNebula/docs that referenced this issue Nov 10, 2022
F OpenNebula/one#5753: Two options for live mem resize
b93b84d
rsmontero pushed a commit to OpenNebula/docs that referenced this issue Nov 28, 2022
F OpenNebula/one#5753: Two options for live mem resize (#2425)
bdcd59c
rsmontero added a commit that referenced this issue Nov 28, 2022
@rsmontero
F #5753: Two options for live memory resize
4136652 
This commit add a new attribute to the VM template MEMORY_RESIZE_MODE.
It can be:

- BALLOONING to increase/decrease the memory balloon
- HOTPLUG to add/remove memory modules to the VM

By default VMs will use BALLOONNING if not specified.
@FrederickBor
Copy link
Contributor

Code: https://github.com/OpenNebula/one-ee/pull/2387

rsmontero pushed a commit that referenced this issue Dec 5, 2022
F #5753: Expose memory resize mode on Sunstone (#2387)
d917a59
@tinova
Copy link
Member

tinova commented Dec 7, 2022

needs sunstone testing

@tinova tinova closed this as completed Dec 13, 2022
@tinova tinova mentioned this issue Dec 13, 2022
Closed
6 tasks
@FrederickBor
Copy link
Contributor

FSunstone testing: https://github.com/OpenNebula/development/pull/2122

feldsam pushed a commit to FELDSAM-INC/one that referenced this issue Nov 4, 2024
@feldsam
F OpenNebula#5753: Better live mem resize for KVM (OpenNebula#1820)
cfdc615 
(cherry picked from commit c6965c3)

# Conflicts:
#	src/fireedge/src/client/constants/vm.js
feldsam pushed a commit to FELDSAM-INC/one that referenced this issue Nov 4, 2024
@feldsam
F OpenNebula#5753: Two options for live memory resize
620ac54 
(cherry picked from commit c6965c3)
Signed-off-by: Kristian Feldsam <[email protected]>

F OpenNebula#5753: Two options for live memory resize

This commit add a new attribute to the VM template MEMORY_RESIZE_MODE.
It can be:

- BALLOONING to increase/decrease the memory balloon
- HOTPLUG to add/remove memory modules to the VM

By default VMs will use BALLOONNING if not specified.

Signed-off-by: Kristian Feldsam <[email protected]>
feldsam pushed a commit to FELDSAM-INC/one that referenced this issue Nov 4, 2024
@feldsam
F OpenNebula#5753: Expose memory resize mode on Sunstone (OpenNebula#…
2e94a1b 
…2387)

Signed-off-by: Kristian Feldsam <[email protected]>

# Conflicts:
#	src/fireedge/src/client/components/Forms/VmTemplate/CreateForm/Steps/General/capacitySchema.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrederickBor FrederickBor

Labels
Category: Sunstone Priority: Normal Sponsored Status: Accepted Type: Feature
Projects
None yet
Milestone
Release 6.6
Development

No branches or pull requests
4 participants
@tinova @rsmontero @FrederickBor @paczerny