Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong LXD deploy exception handling #4977

Closed
7 tasks
vholer opened this issue Jul 14, 2020 · 0 comments
Closed
7 tasks

Wrong LXD deploy exception handling #4977

vholer opened this issue Jul 14, 2020 · 0 comments
Labels
Category: LXD/LXC Status: Accepted Type: Bug
Milestone
Release 5.12.2

Comments

@vholer
Copy link
Contributor

vholer commented Jul 14, 2020

Description

On LXD deploy error, the exception handling code syntax is wrong:

one/src/vmm_mad/remotes/lxd/deploy

Line 72 in 500017b

rescue e

and might fail on

Tue Jul 14 11:02:47 2020 [Z0][VMM][I]: /var/tmp/one/vmm/lxd/deploy:72:in `rescue in <main>': undefined local variable or method `e' for main:Object (NameError)
Tue Jul 14 11:02:47 2020 [Z0][VMM][I]: from /var/tmp/one/vmm/lxd/deploy:69:in `<main>'
Tue Jul 14 11:02:47 2020 [Z0][VMM][I]: ExitCode: 1
Tue Jul 14 11:02:47 2020 [Z0][VMM][I]: Failed to execute virtualization driver operation: deploy.

To Reproduce
E.g., drop necessary bridges (with dummy network driver), deploy LXD VM and get failure.

Details

  • Affected Component: VM drivers
  • Hypervisor: LXD
  • Version: 5.10+

Progress Status

  • Branch created
  • Code committed to development branch
  • Testing - QA
  • Documentation
  • Release notes - resolved issues, compatibility, known issues
  • Code committed to upstream release/hotfix branches
  • Documentation committed to upstream release/hotfix branches
@vholer vholer added this to the Release 5.12.2 milestone Jul 14, 2020
rsmontero pushed a commit that referenced this issue Jul 15, 2020
@dann1 @rsmontero
B #4977: Generate e (#98)
edd5162 
Co-authored-by: Daniel Clavijo Coca <[email protected]>
(cherry picked from commit a40e394)
@dann1 dann1 closed this as completed Jul 15, 2020
atodorov-storpool pushed a commit to storpool/one that referenced this issue Jul 23, 2020
@dann1 @atodorov-storpool
B OpenNebula#4977: Generate e (OpenNebula#98)
f541b72 
Co-authored-by: Daniel Clavijo Coca <[email protected]>
(cherry picked from commit a40e394)
rsmontero pushed a commit that referenced this issue Oct 6, 2020
@dann1 @rsmontero
B #4977: Generate e (#98)
9d89705 
Co-authored-by: Daniel Clavijo Coca <[email protected]>
rsmontero pushed a commit that referenced this issue Jan 20, 2021
@dann1 @rsmontero
B #4977: Generate e (#98)
b28138f 
Co-authored-by: Daniel Clavijo Coca <[email protected]>
(cherry picked from commit a40e394)
rsmontero pushed a commit that referenced this issue Apr 13, 2021
@dann1 @rsmontero
B #4977: Generate e (#98)
7cc8b18 
Co-authored-by: Daniel Clavijo Coca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: LXD/LXC Status: Accepted Type: Bug
Projects
None yet
Milestone
Release 5.12.2
Development

No branches or pull requests
2 participants
@vholer @dann1