Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onehook CLI improvements #4203

Closed
7 tasks
vholer opened this issue Feb 18, 2020 · 4 comments
Closed
7 tasks

onehook CLI improvements #4203

vholer opened this issue Feb 18, 2020 · 4 comments

Comments

@vholer
Copy link
Contributor

vholer commented Feb 18, 2020

Description

Following easy improvements might be considered for onehook CLI tool:

  1. command doesn't expand to the terminal width as other commands
  2. hook delete fails when provided with hook name
$ onehook delete refresh_dns_create-0
/usr/lib/one/ruby/cli/one_helper.rb:859:in `perform_actions': undefined method `each' for "refresh_dns_create-0":String (NoMethodError)
	from /usr/bin/onehook:175:in `block (2 levels) in <main>'
	from /usr/lib/one/ruby/cli/command_parser.rb:470:in `call'
	from /usr/lib/one/ruby/cli/command_parser.rb:470:in `run'
	from /usr/lib/one/ruby/cli/command_parser.rb:84:in `initialize'
	from /usr/bin/onehook:40:in `new'
	from /usr/bin/onehook:40:in `<main>'

Progress Status

  • Branch created
  • Code committed to development branch
  • Testing - QA
  • Documentation
  • Release notes - resolved issues, compatibility, known issues
  • Code committed to upstream release/hotfix branches
  • Documentation committed to upstream release/hotfix branches
@al3xhh
Copy link
Contributor

al3xhh commented Feb 18, 2020

@vholer
Copy link
Contributor Author

vholer commented Feb 18, 2020

Note: change in config is not for one-5.10

@rsmontero
Copy link
Member

ok will split in two so we can have the functionality 5.10.x

al3xhh pushed a commit to al3xhh/one that referenced this issue Feb 18, 2020
al3xhh pushed a commit to al3xhh/one that referenced this issue Feb 18, 2020
@al3xhh
Copy link
Contributor

al3xhh commented Feb 18, 2020

@rsmontero change done! @vholer thanks for the heads up!!

rsmontero pushed a commit that referenced this issue Feb 18, 2020
rsmontero pushed a commit that referenced this issue Feb 18, 2020
rsmontero added a commit that referenced this issue Feb 18, 2020
rsmontero pushed a commit that referenced this issue Feb 18, 2020
(cherry picked from commit 41644b7)
rsmontero pushed a commit to OpenNebula/docs that referenced this issue Feb 18, 2020
atodorov-storpool pushed a commit to storpool/one that referenced this issue Feb 20, 2020
al3xhh pushed a commit to al3xhh/one that referenced this issue Feb 20, 2020
rsmontero pushed a commit that referenced this issue Feb 20, 2020
rsmontero pushed a commit that referenced this issue Feb 20, 2020
(cherry picked from commit b6fc504)
atodorov-storpool pushed a commit to storpool/one that referenced this issue Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants