Docker testing publish #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bg/163 publish docker image
|
I think we can have the publish workflow to run only a specific branch or tag, and the build needs to run on every PR to check the Docker-file |
chinmayshah99
suggested changes
Jun 6, 2020
| - name: Run tests | ||
| run: | ||
| | # Not sure if this is what is desired. If a test fails the whole build fails - can mark flaky tests if needed? | ||
| docker run ${{steps.build_name.outputs.image_name}}:latest /bin/bash -c "pipenv install --dev && pipenv run pytest ./tests" |
There was a problem hiding this comment.
This can be a separate workflow
There was a problem hiding this comment.
I think it would be nicer to run the tests against the docker images before pushing them out the door.
It won't add much to the total time taken to run the action. And the final shipped artifact will be identical.
There was a problem hiding this comment.
We want to run docker tests one each commit.
But publishing it to dockerhub is not something we want to do for each commit
… Otherwise all our stuff will break unexpectedly. Better to formally pull in deps. However, I see doesn't have any releases yet.
…tedly. Include python 3.5 in build images
…n. Using git submodule to ensure we pull in the correct version of 3rd code.
…t env vars to the appropriate virtual env so users can simply run
|
Remaining items:
Notes: I made changes the the Dockerfile as it cloned the |
chinmayshah99
suggested changes
Jun 10, 2020
chinmayshah99
previously approved these changes
Jun 18, 2020
It made sense, as people using docker for development already have third-party folder cloned.
|
Hey @BenjaminDev thanks for the PR. Why don't you join us on Slack? |
BenjaminDev
pushed a commit
to BenjaminDev/PyDP
that referenced
this pull request
Jul 3, 2020
changed import Clone submodules as well so we can peg to a SHA and not break unexpectedly. Include python 3.5 in build images remove 3rd party from ignore and clone the submodule instead. Remove cloning 3rd party deps as it was not pegged to a SHA or version. Using git submodule to ensure we pull in the correct version of 3rd code. explicity stated the pipenv place the venv inside the project dir. Set env vars to the appropriate virtual env so users can simply run updated python version arg to upper case remove debugging debugging GITHUB_SHA debugging GITHUB_SHA removed debugging added git checkout for sub-mod to specific version style fix changed import fix typo in dockerfile added checks for python, bazel & pipenv install bazel using binary installer switched back add check pipenv for linux (OpenMined#160) * add check for pipenv * Update prereqs_linux.sh * replace apt with pip * use python -c to check if pipenv is installed * use pip3 and python3 * call python instead of python3 * use python3 instead of python * check pythong using --version * add elif to double check python Utils Bindings (OpenMined#180) * utils bindings * style fix * more bindings and tests * more bindings and tests * bindings for add,subtract and sqaure * style fix and TODO added * throwing runtime error during invalid operations * removed TODO Added Docker hub publish (OpenMined#176) * added github workflow to publish the docker image. Runs test suit as a sanity check. * Update update-docker-image.yml * Update update-docker-image.yml * Update update-docker-image.yml * Update update-docker-image.yml * added builds for all python versions. * syntax * formatting remove spaces. * testing * shuffle the image name concatenation. * need to references from steps level * need to references from steps level * Fix docker args. hyphens are illegal it seems. * WIP. need to version upstream deps like thet base dp lib from google. Otherwise all our stuff will break unexpectedly. Better to formally pull in deps. However, I see doesn't have any releases yet. * Clone submodules as well so we can peg to a SHA and not break unexpectedly. Include python 3.5 in build images * remove 3rd party from ignore and clone the submodule instead. * Remove cloning 3rd party deps as it was not pegged to a SHA or version. Using git submodule to ensure we pull in the correct version of 3rd code. * explicity stated the pipenv place the venv inside the project dir. Set env vars to the appropriate virtual env so users can simply run * updated python version arg to upper case * remove debugging * debugging GITHUB_SHA * debugging GITHUB_SHA * removed debugging * added docker publish stuff * added third_party yet again to docker file It made sense, as people using docker for development already have third-party folder cloned. * disabled docker hub push on every release Co-authored-by: Chinmay Shah <[email protected]> Added error handling (OpenMined#188) * added bascic exception handling * added error handling for bounded functions * added error handling for order statistics * fixed cpp style fixing issue OpenMined#92 clang-format added sample error handling code 0.1.3 release ready Update update-docker-image.yml changes in sha version of DP library docker tagging fix Update update-docker-image.yml 0.1.3 -> 0.1.4 added docker publish stuff added third_party yet again to docker file It made sense, as people using docker for development already have third-party folder cloned. disabled docker hub push on every release
dvadym
pushed a commit
to dvadym/PyDP
that referenced
this pull request
Jul 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Publish to Docker Hub so it's easy for people to try out the library.
Changes:
Notes: Dev dependencies are not baked into the image but only used to run tests.
Fixes #163
Affected Dependencies
None
Type of Change
Please mark options that are relevant.
How has this been tested?
dev. Note: make sure your github repo settings enables actions to run. Seems my defaults for forks in not to run the actions.Checklist
Additional Context
Questions to conclude this PR
I'm super happy to complete these but someone who knows those answers can pop them in and take over if they would like.