Enabled windows build #460
Conversation
| @@ -8,7 +8,8 @@ | |||
| ], | |||
| "sourceMap": true, | |||
| "rootDir": "src", | |||
| "strict": true /* enable all strict type-checking options */ | |||
| "strict": true, /* enable all strict type-checking options */ | |||
| "skipLibCheck": true /* ignoring type checking for third-party libraries */ | |||
There was a problem hiding this comment.
Is it required to skip checking the types in third-party libraries? What would be the purpose of skipping type safety in third-party libraries? Kindly provide a comment explaining the purpose if this is a necessity.
There was a problem hiding this comment.
After updating the TypeScript version in package-lock.json, the Mac and Linux builds started failing, while the Windows build is working fine. The failure is due to a ‘WebSocket’ error in index.ts in selenium-driver library. We are excluding 'node_modules', it seems the compiler is still processing files within that folder. The error occurs during the TypeScript compilation process. Although we are excluding 'node_modules', it seems the compiler is still processing files within that folder. The 'skipLibCheck' parameter skips the compilation of third-party libraries in the node_modules directory. After adding this change, all the builds across different environments started working.
There was a problem hiding this comment.
The skipLibCheck parameter does not necessarily skips the compilation of third-party libraries in the node_modules directory. Instead it skips type safety check in third-party libraries. Can we upgrade selenium-webdriver library?
There was a problem hiding this comment.
sorry, I meant to say that 'skipLibCheck' bypasses type checking for declaration files during compilation. I had attempted to upgrade 'selenium-webdriver', but it resulted in dependency conflicts within node_modules. As a work around I enabled 'skipLibCheck' to avoid this type conflicts.
Fixes #451 and #265
The GHA build failures on Windows OS were resolved in the latest version of the VS Code extension tester. Following the update, the Windows build started functioning correctly.