feat: add ability to not log banner when running a task #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on run task Signed-off-by: Godot Bian <[email protected]>
jusiskin
approved these changes
Jan 21, 2025
jusiskin
changed the title
jusiskin
changed the title
jericht
approved these changes
Jan 21, 2025
jairaws
approved these changes
Jan 21, 2025
This was referenced Feb 25, 2025
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Consumers of the
openjd_sessionsmodule may want to control the task log banners by turning it off. Additionally, they can use _logging.py to pass log the banner of their choice.What was the solution? (How)
Add an argument
log_task_bannertorun_taskto optionally turn off the banner logging. By default, the task banner logging is set toTrue.What is the impact of this change?
Consumers of the
openjd_sessionsmodule is able to turn off the banner logging forrun_task.How was this change tested?
See DEVELOPMENT.md for information on running tests.
Was this change documented?
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.