-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add osd/srt support #53
base: main
Are you sure you want to change the base?
Conversation
@henkwiedig Glad to have this feature. It's good to render OSD with https://github.com/avsaase/walksnail-osd-tool It wroks fine: latest msposd(2607aa1) + msposd: support osd/srt files for raw video/osd speration
Is it possible for msposd to recognize the flag or Then we can simply configure the msposd to record or NOT. What do you think? BTW, currently, I use main branch msposd which don't have this patch. The patch file is on ground station. |
I didn't quite get your point. On Air side: @tipoman9 |
@lida2003 srt file recording including the MSPOSD.msg should work now |
It should be OK “When not using --subtitle , we currently skip the file recording”, as no video no osd is acceptable.
I don't think osd will be recorded on airunit, as mp4 is recorded by majestic, which don't have osd input.
Yes, that's exactly what we are talking about. And we need some backup method to ensure the video footage secure and safely recorded for cases: crash/sd damage/gs failure etc. Well, the above concers really depends on how user will use the application. Here is my user case:
It should be airunit(raw video + .osd/.srt) + gs(raw video + .osd/.srt). Regarding the timing synchronization mechanism, there are two sets of .mp4/.osd/.srt. And currently, I use the above configuration + disable air unit raw video recording most of time.
No, I don't think there is such a need, but impress me with the requirement with detailed description. |
.srt file is empty. EDIT: BTW, walksnail-osd-tool 0.3.0 will exit when loading .srt/.osd, especially .srt is empty. It will exit when mp4 sometime. @henkwiedig Have you met this issue? Or how to solve? |
walksnail-osd-tool crash: empty srt file: |
Yes, I have created an issue. Not only empty srt file.
I have recorded for about 1:49, which has only one message.
|
As it's writeing "something" i still think this is a buffer issue. Added fflush() after each frame. Should also prevent data loss in case of sudden powerloss. |
This PR will add osd/srt file writeing support.
See Readme.
Works on ground and air mode but in air mode majestic needs to be configured to not write to a subdirectory:
/mnt/mmcblk0p1/%F/..
Fixes: #35
@lida2003 please test as well