Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize and make Container image rootless #42

Merged
merged 9 commits into from
Feb 18, 2025

Conversation

Macleykun
Copy link
Contributor

What's changed?

I've re-arranged and optimized the Containerfile inorder for it to properly use caching, so that only the images are rebuild of which there files have changed. So we don't build the dependencies everytime but instead only copy the files first that collects all the dependencies, build deps, cache this all and then we copy the source code and compile which changes more often.

Also made it rootless but i haven't tested this out yet.

Regarding this all, i've noticed a few things i would like to ask your opinion of:

  • Would you be ok to change Dockerfile to Containterfile and favor using podman more of docker? Because it's more conform of the OCI standards aswell as being rootless by default (generally also more liked by the community).
  • Instead of docker-compose, that we make it container-compose
  • Instead of using postgresql that we use the alpine variant that's a bit smaller?

@GwonHyeok
Copy link
Member

@Macleykun

Thank you for your contribution.

Is it possible to change to container, container-compose and still keep docker, podman compatible?

Also, postgresql image lightweighting seems like a good idea.

@Macleykun
Copy link
Contributor Author

@Macleykun

Thank you for your contribution.

Is it possible to change to container, container-compose and still keep docker, podman compatible?

Also, postgresql image lightweighting seems like a good idea.

np! i happen to find this project at a time that felt a bit to much of a coincidence and decided to look for anything i could contribute to :)

Changing Dockerfile to Containerfile can be done withoud a problem, people who use docker do need to specify the file with the -t flag:
image

Same for container-compose.yml:
image
(ofcours ignore the error :P)

if your ok with it, i'll edit the docs to explain both docker and podman :)

@GwonHyeok
Copy link
Member

@Macleykun

OK.
Change to Containerfile and container-compose.yaml format and update the description in the
README.md with the relevant descriptions and we'll check it out!

@Macleykun
Copy link
Contributor Author

@Macleykun

OK. Change to Containerfile and container-compose.yaml format and update the description in the README.md with the relevant descriptions and we'll check it out!

heyo
made the changes :)
Also, if you have the time/would like, would you have a look at #40 after this one is merged? It's a less dramatic change but helps you keeping the images up-to-date and create new versions when you tag your releases!

@carlucci001
Copy link

carlucci001 commented Feb 17, 2025 via email

Copy link

vercel bot commented Feb 18, 2025

@Macleykun is attempting to deploy a commit to the learners Team on Vercel.

A member of the Team first needs to authorize it.

@Macleykun
Copy link
Contributor Author

@carlucci001 sure, is there a place you like to chat more one on one? I use Discord myself

@carlucci001
Copy link

carlucci001 commented Feb 18, 2025 via email

@GwonHyeok
Copy link
Member

we'll merge that PR.

Let's also check the #40

@GwonHyeok GwonHyeok merged commit 2b93ab6 into OpenHealthForAll:main Feb 18, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants