-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize and make Container image rootless #42
Conversation
Thank you for your contribution. Is it possible to change to container, container-compose and still keep docker, podman compatible? Also, postgresql image lightweighting seems like a good idea. |
OK. |
heyo |
I would like to assist my fellow disabled veterans with a new tool that
will help them stay on track with their healthcare conditions.
I think I have most of the prerequisite for getting this up and running. If
anybody could assist me, I would be happy to pay them for this.Thank you
…On Mon, Feb 17, 2025, 3:14 AM Macley ***@***.***> wrote:
@Macleykun <https://github.com/Macleykun>
OK. Change to Containerfile and container-compose.yaml format and update
the description in the README.md with the relevant descriptions and we'll
check it out!
heyo
made the changes :)
Also, if you have the time/would like, would you have a look at #40
<#40> after this one
is merged? It's a less dramatic change but helps you keeping the images
up-to-date and create new versions when you tag your releases!
—
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPQVBPUDK3M63V5IFMZXOL2QGK77AVCNFSM6AAAAABW5ZUGWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRSGM2TEMZSHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
[image: Macleykun]*Macleykun* left a comment
(OpenHealthForAll/open-health#42)
<#42 (comment)>
@Macleykun <https://github.com/Macleykun>
OK. Change to Containerfile and container-compose.yaml format and update
the description in the README.md with the relevant descriptions and we'll
check it out!
heyo
made the changes :)
Also, if you have the time/would like, would you have a look at #40
<#40> after this one
is merged? It's a less dramatic change but helps you keeping the images
up-to-date and create new versions when you tag your releases!
—
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPQVBPUDK3M63V5IFMZXOL2QGK77AVCNFSM6AAAAABW5ZUGWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRSGM2TEMZSHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@Macleykun is attempting to deploy a commit to the learners Team on Vercel. A member of the Team first needs to authorize it. |
@carlucci001 sure, is there a place you like to chat more one on one? I use Discord myself |
i have a channel i haven't used in a bit carlucci001 And thank you very
much for responding.
Carl Farrington
Website: https://farringtondevelopment.com
Email: ***@***.***
Phone: 828.215.5584
Skype: carlucci001
…On Tue, Feb 18, 2025 at 7:10 AM Macley ***@***.***> wrote:
@carlucci001 <https://github.com/carlucci001> sure, is there a place you
like to chat more one on one? I use Discord myself
—
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPQVBOTPXYKJ5L4FHNQXHT2QMPNFAVCNFSM6AAAAABW5ZUGWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRVGUYTQMBSGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: Macleykun]*Macleykun* left a comment
(OpenHealthForAll/open-health#42)
<#42 (comment)>
@carlucci001 <https://github.com/carlucci001> sure, is there a place you
like to chat more one on one? I use Discord myself
—
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPQVBOTPXYKJ5L4FHNQXHT2QMPNFAVCNFSM6AAAAABW5ZUGWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRVGUYTQMBSGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
we'll merge that PR. Let's also check the #40 |
What's changed?
I've re-arranged and optimized the Containerfile inorder for it to properly use caching, so that only the images are rebuild of which there files have changed. So we don't build the dependencies everytime but instead only copy the files first that collects all the dependencies, build deps, cache this all and then we copy the source code and compile which changes more often.
Also made it rootless but i haven't tested this out yet.
Regarding this all, i've noticed a few things i would like to ask your opinion of: